Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6b197ee
Choose a base ref
...
head repository: morrisonlevi/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6be654a
Choose a head ref
  • 20 commits
  • 28 files changed
  • 1 contributor

Commits on Dec 29, 2018

  1. Configuration menu
    Copy the full SHA
    6819342 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    274ad54 View commit details
    Browse the repository at this point in the history
  3. Add more variance support

    todo: add runtime support when ce cannot be found
    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    e1d8606 View commit details
    Browse the repository at this point in the history
  4. Refactor

    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    c318691 View commit details
    Browse the repository at this point in the history
  5. Groundwork for runtime variance

    Still need to collect and then generate ZEND_VERIFY_VARIANCE opcodes
    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    00d9439 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7316918 View commit details
    Browse the repository at this point in the history
  7. Add runtime variance checks

    Known issues:
      - When there is an inheritance warning it gets generated twice.
      - The VERIFY_VARIANCE opcode is not generated in the correct place
    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    41fa626 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    131ec50 View commit details
    Browse the repository at this point in the history
  9. Add test for bug 76451

    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    c1b0f6c View commit details
    Browse the repository at this point in the history
  10. Fix variance verification for anonymous classes

    Refactor a bit of variance verification compilation.
    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    ea9497a View commit details
    Browse the repository at this point in the history
  11. Do not re-issue inheritance *warnings* at runtime

    Fix bad error message
    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    43d79a1 View commit details
    Browse the repository at this point in the history
  12. Cleanup

    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    3dc2312 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6b9394b View commit details
    Browse the repository at this point in the history
  14. Fix comment style

    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    6f3dfa2 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7e75361 View commit details
    Browse the repository at this point in the history
  16. Add/remove some comments

    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    89dd30a View commit details
    Browse the repository at this point in the history
  17. Fix contravariant check with iterable

    Fixes this under opcache:
    
    class A {
      function m(Traversable $z) {}
    }
    
    class B extends A {
      function m(iterable $z) {}
    }
    
    Also fixes cases where A::m is Iterator, IteratorAggregate, etc.
    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    e27890f View commit details
    Browse the repository at this point in the history
  18. Fix covariant check with iterable

    Fixes this under opcache:
    
    class A {
      function m(): iterable {}
    }
    
    class B extends A {
      function m(): Traversable {}
    }
    
    Also fixes cases where B::m is Iterator, IteratorAggregate, etc.
    morrisonlevi committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    93aab70 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    acd3ec6 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. Configuration menu
    Copy the full SHA
    6be654a View commit details
    Browse the repository at this point in the history
Loading