Fix string ownership in _compile_verify_variance

morrisonlevi · morrisonlevi · commit acd3ec6458b3 · 2018-12-29T15:30:02.000-07:00
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
@@ -4131,7 +4131,7 @@ static void _compile_verify_variance(HashTable *unverified_types)
 		zend_op *opline = get_next_op();
 		opline->op1_type = IS_CONST;
 		opline->opcode = ZEND_VERIFY_VARIANCE;
-		LITERAL_STR(opline->op1, lcname);
+		LITERAL_STR(opline->op1, zend_string_copy(lcname));
 	} ZEND_HASH_FOREACH_END();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4131,7 +4131,7 @@ static void _compile_verify_variance(HashTable *unverified_types)`
`4131`	`4131`	`zend_op *opline = get_next_op();`
`4132`	`4132`	`opline->op1_type = IS_CONST;`
`4133`	`4133`	`opline->opcode = ZEND_VERIFY_VARIANCE;`
`4134`		`- LITERAL_STR(opline->op1, lcname);`
	`4134`	`+ LITERAL_STR(opline->op1, zend_string_copy(lcname));`
`4135`	`4135`	`} ZEND_HASH_FOREACH_END();`
`4136`	`4136`	`}`
`4137`	`4137`