-
Notifications
You must be signed in to change notification settings - Fork 8k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: morrisonlevi/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: variance2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 20 commits
- 28 files changed
- 1 contributor
Commits on Dec 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 6819342 - Browse repository at this point
Copy the full SHA 6819342View commit details -
Configuration menu - View commit details
-
Copy full SHA for 274ad54 - Browse repository at this point
Copy the full SHA 274ad54View commit details -
todo: add runtime support when ce cannot be found
Configuration menu - View commit details
-
Copy full SHA for e1d8606 - Browse repository at this point
Copy the full SHA e1d8606View commit details -
Configuration menu - View commit details
-
Copy full SHA for c318691 - Browse repository at this point
Copy the full SHA c318691View commit details -
Groundwork for runtime variance
Still need to collect and then generate ZEND_VERIFY_VARIANCE opcodes
Configuration menu - View commit details
-
Copy full SHA for 00d9439 - Browse repository at this point
Copy the full SHA 00d9439View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7316918 - Browse repository at this point
Copy the full SHA 7316918View commit details -
Known issues: - When there is an inheritance warning it gets generated twice. - The VERIFY_VARIANCE opcode is not generated in the correct place
Configuration menu - View commit details
-
Copy full SHA for 41fa626 - Browse repository at this point
Copy the full SHA 41fa626View commit details -
Configuration menu - View commit details
-
Copy full SHA for 131ec50 - Browse repository at this point
Copy the full SHA 131ec50View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1b0f6c - Browse repository at this point
Copy the full SHA c1b0f6cView commit details -
Fix variance verification for anonymous classes
Refactor a bit of variance verification compilation.
Configuration menu - View commit details
-
Copy full SHA for ea9497a - Browse repository at this point
Copy the full SHA ea9497aView commit details -
Do not re-issue inheritance *warnings* at runtime
Fix bad error message
Configuration menu - View commit details
-
Copy full SHA for 43d79a1 - Browse repository at this point
Copy the full SHA 43d79a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dc2312 - Browse repository at this point
Copy the full SHA 3dc2312View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b9394b - Browse repository at this point
Copy the full SHA 6b9394bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f3dfa2 - Browse repository at this point
Copy the full SHA 6f3dfa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e75361 - Browse repository at this point
Copy the full SHA 7e75361View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89dd30a - Browse repository at this point
Copy the full SHA 89dd30aView commit details -
Fix contravariant check with iterable
Fixes this under opcache: class A { function m(Traversable $z) {} } class B extends A { function m(iterable $z) {} } Also fixes cases where A::m is Iterator, IteratorAggregate, etc.Configuration menu - View commit details
-
Copy full SHA for e27890f - Browse repository at this point
Copy the full SHA e27890fView commit details -
Fix covariant check with iterable
Fixes this under opcache: class A { function m(): iterable {} } class B extends A { function m(): Traversable {} } Also fixes cases where B::m is Iterator, IteratorAggregate, etc.Configuration menu - View commit details
-
Copy full SHA for 93aab70 - Browse repository at this point
Copy the full SHA 93aab70View commit details -
Configuration menu - View commit details
-
Copy full SHA for acd3ec6 - Browse repository at this point
Copy the full SHA acd3ec6View commit details
Commits on Dec 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 6be654a - Browse repository at this point
Copy the full SHA 6be654aView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...variance2