jQuery Checkall checkbox

Question

I cant get this checkbox to check the checkboxs which are not hidden

Basiclly I need it to not check any check box in the table which is hidden from view

ui-tableFilter-hidden

$("input:checkbox.checkall").live('click', function(event){
    var checkedStatus = this.checked;
    if(!$('table tbody tr').hasClass('ui-tableFilter-hidden'))
    {
        $("td.small input:checkbox").each(function() {
            this.checked = checkedStatus;
        });
    }
});

Quick fix was to replace the above code with this one

$("input:checkbox.checkall").live('click', function(event){
    var checkedStatus = this.checked;

        $("td.small input[type=checkbox]:visible").each(function() {
            this.checked = checkedStatus;
        });

});

Can you put together a jsFiddle?

Sparky
– Sparky

2011-10-23 23:17:32 +00:00
Commented Oct 23, 2011 at 23:17 — Sparky
– Sparky, Commented Oct 23, 2011 at 23:17
You should also use the change event in your answer.

ima007
– ima007

2011-10-23 23:28:08 +00:00
Commented Oct 23, 2011 at 23:28 — ima007
– ima007, Commented Oct 23, 2011 at 23:28

BZink · Accepted Answer · 2011-10-23 23:21:45Z

1

Your IF check and the EACH loop are unrelated in the code above. The IF will evaluate to true at some point and then the EACH loop will iterate through all checkboxes matching the selector, regardless of what you checked in the IF.

Try something like this instead...

$('table tbody tr')each(function(){
    if(!$(this).hasClass('ui-tableFilter-hidden')){
           $(this).find("td.small input:checkbox").each(function() {
                this.checked = checkedStatus;
            });
        }
    }

answered Oct 23, 2011 at 23:21

BZink

7,99110 gold badges41 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ima007 Over a year ago

No need to loop through the rows -- as the OP figured out himself, you can use the :visible pseudo selector, or as I posted, you can search for all rows without the class ui-tableFilter-hidden.

ima007 · Accepted Answer · 2011-10-23 23:25:22Z

0

Ideally, you should be using the change event, since inputs can be altered with more than just clicks. You can also just find all rows with the ui-tableFilter-hidden, then check the appropriate checkboxes. I also use prop to identify the checked state of the box, available as of jQuery 1.6, although this.checked should work as well.

$("input:checkbox.checkall").change(function(){
    var jCheckAll = $(this);
    var checkedStatus = jCheckAll.prop("checked");
    var jRows = $('table tbody tr:not(.ui-tableFilter-hidden)');
    jRows.find("td.small input:checkbox").prop("checked",checkedStatus);
});

edited Oct 23, 2011 at 23:25

answered Oct 23, 2011 at 23:20

ima007

4773 silver badges12 bronze badges

2 Comments

RussellHarrower Over a year ago

I ended up using $('input[type=checkbox]:visible')

ima007 Over a year ago

Edited my code to reflect the fact that you wanted rows that don't have that class. Your method is simpler, though! Just make sure to use the change event.

Collectives™ on Stack Overflow

jQuery Checkall checkbox

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related