Function Proxy .toString() Errors

Question

I am trying to call .toString() on a function proxy.

Simply creating a function proxy and calling toString causes "TypeError: Function.prototype.toString is not generic", setting the toString to return the source of the original causes "RangeError: Maximum call stack size exceeded", but creating a get trap for toString works.

Why does simply setting the toString function not work, but making a get trap does?

function wrap(source) {
 return(new Proxy(source, {}))
}
wrap(function() { }).toString()

function wrap(source) {
 let proxy = new Proxy(source, {})
 proxy.toString = function() {
  return(source.toString())
 }
 return(proxy)
}
wrap(function() { }).toString()

function wrap(source) {
 return(new Proxy(source, {
  get(target, key) {
   if(key == "toString") {
    return(function() {
     return(source.toString())
    })
   } else {
    return(Reflect.get(source, key))
} } })) }
wrap(function() { }).toString()

Unrelated: return is a keyword, not a function in itself, so it's return x not return(x). The parens doesn't do anything here. — Albin
– Albin, Commented Feb 24, 2018 at 1:34

Steve Kehlet · Accepted Answer · 2017-02-25 21:31:59Z

8

I was having the same issue. I finally figured out that it's an issue with this. Add a get trap to your handler, bind the proxied object as this on the proxied property if it's a function, and it seems to work okay:

function wrap(source) {
    return new Proxy(source, {
        get: function (target, name) {
            const property = target[name];
            return (typeof property === 'function') 
                ? property.bind(target)
                : property;
        }
    });
}

console.log(wrap(function () {}).toString());

answered Feb 25, 2017 at 21:31

Steve Kehlet

6,5065 gold badges43 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Qwertiy · Accepted Answer · 2016-07-11 22:27:38Z

2

TypeError: Function.prototype.toString is not generic

Seems like Function.prototype.toString is not supposed to be called on Proxy.

proxy.toString = function() {

This assignment to proxy is passed to the source object as you do not have trap for assignment. If you check source.hasOwnProperty('toString') you'll get true. When you add get trap, you don't change toString method and don't add it into source object, so it works.

The other possible solution is

function wrap(source) {
  let proxy = new Proxy(source, {})
  proxy.toString = Function.prototype.toString.bind(source)
  return proxy
}

answered Jul 11, 2016 at 22:27

Qwertiy

21.9k17 gold badges69 silver badges143 bronze badges

Collectives™ on Stack Overflow

Function Proxy .toString() Errors

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related