Using jQuery to change the background image

Question

I am trying to change the background image of a link when it get clicked. I keep getting the error that you cannot call 'click' on null.

JQuery (in the header)

<script type="text/javascript">
    $('a.upvote-arrow').click(function(){
        $('#tempid1').css('background-image','url(../images/icons/up-arrow2.png)');
    });
</script>

HTML

<div class="top-comment-vote">
    <a href="#" class="upvote-arrow" title="Up vote" id="tempid1"></a>
</div>

Thanks

mgraph · Accepted Answer · 2012-06-29 22:25:18Z

1

Try adding $(document).ready:

<script type="text/javascript">
$(document).ready(function(){
    $('a.upvote-arrow').click(function(){
        $(this).css('background-image','url(../images/icons/up-arrow2.png)');
    });
})
</script>

answered Jun 29, 2012 at 22:25

mgraph

15.3k4 gold badges43 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Danconia Over a year ago

Thanks for the quick answer. I did that I now I got an 'Uncaught SyntaxError: Unexpected end of input'

Danconia Over a year ago

thanks, got it to work, the problem was that the '$' was conflicted, so I had to do var $j = jQuery.noConflict();. Thanks, it now works!

Alex Grande · Accepted Answer · 2012-06-29 22:26:57Z

1

Are you sure this script is being loaded after the html is in the DOM?

Try wrapping what you wrote in a onload closure.

$(function() {
 $('a.upvote-arrow').click(function(){
   $('#tempid1').css('background-image','url(../images/icons/up-arrow2.png)');
 });
});

Another thing you can do is take advantage of delegation for the event registration.

$('body').on("click", ".a.upvote-arrow", function(){
 $('#tempid1').css('background-image','url(../images/icons/up-arrow2.png)');
});

This binds it to the body instead.

answered Jun 29, 2012 at 22:26

Alex Grande

8,0271 gold badge29 silver badges30 bronze badges

Comments

zallarak · Accepted Answer · 2012-06-29 22:25:36Z

0

Try wrapping your script with document.ready; I suspect that you're script might be running before your entire page loads.

answered Jun 29, 2012 at 22:25

zallarak

5,5758 gold badges45 silver badges54 bronze badges

Collectives™ on Stack Overflow

Using jQuery to change the background image

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related