Skip to content

Conversation

@MasterOdin
Copy link
Contributor

No description provided.

@sbrl
Copy link
Member

sbrl commented May 2, 2021

Looks good!

@owenvoke, is there anything else we need to do here? I'm unsure how the tldr.zip is automatically updated, so I'm hesitant to just do the branch rename here.

@bl-ue
Copy link

bl-ue commented May 2, 2021

@sbrl the zip itself is generated by this script, and then committed and pushed to this repository right here.

@owenvoke
Copy link
Member

owenvoke commented May 2, 2021

As @bl-ue mentioned, it is updated by the scripts in the CI workflow. Looks like it just does a clone by default, so it should pull whatever the default branch is (hopefully that means we don't really have to update anything in the scripts, as it will automatically change to main).

So, rename the default branch and merge I think...

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @owenvoke!

Looks good to me.

@navarroaxel navarroaxel merged commit 18e423e into main Jul 24, 2021
@navarroaxel navarroaxel deleted the MasterOdin-patch-1 branch July 24, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants