Skip to content

[12.x] EnumerateValues::value() support and return negative values if exists #54910 #57566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
Merged

[12.x] EnumerateValues::value() support and return negative values if exists #54910 #57566

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
813c389
Improve the EnumerateValues::value() for returns value from first ite…
rafaelqueiroz Oct 28, 2025
e2352ad
Improve the EnumerateValues::value() for returns value from first ite…
rafaelqueiroz Oct 28, 2025
9e3412d
Update EnumeratesValues.php
taylorotwell Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve the EnumerateValues::value() for returns value from first ite… 
…m in negative case
  • Loading branch information
@rafaelqueiroz
rafaelqueiroz committed Oct 28, 2025
commit e2352adf3f905f471788097b1da2a92b72b327d2
20 changes: 20 additions & 0 deletions tests/Support/SupportCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,26 @@ public function testValueUsingEnum($collection)
$this->assertEquals(StaffEnum::Joe, $c->where('id', 2)->value('name'));
}

#[DataProvider('collectionClassProvider')]
public function testValueWithNegativeValue($collection)
{
$c = new $collection([['id' => 1, 'balance' => 0], ['id' => 2, 'balance' => 200]]);

$this->assertEquals(0, $c->value('balance'));

$c = new $collection([['id' => 1, 'balance' => ''], ['id' => 2, 'balance' => 200]]);

$this->assertEquals('', $c->value('balance'));

$c = new $collection([['id' => 1, 'balance' => null], ['id' => 2, 'balance' => 200]]);

$this->assertEquals(null, $c->value('balance'));

$c = new $collection([['id' => 1], ['id' => 2, 'balance' => 200]]);

$this->assertEquals(200, $c->value('balance'));
}

#[DataProvider('collectionClassProvider')]
public function testBetween($collection)
{
Expand Down