Skip to content

[12.x] Add Http::batch #56946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 29, 2025
Merged

[12.x] Add Http::batch #56946

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b4db1bf
Create HTTP Pool progress hook
WendellAdriel Sep 5, 2025
8177e3b
Create HTTP Pool catch hook
WendellAdriel Sep 5, 2025
31a229f
Create HTTP Pool then hook
WendellAdriel Sep 5, 2025
d138161
Create HTTP Pool finally hook
WendellAdriel Sep 5, 2025
05e2993
Update implementation to add Http::batch
WendellAdriel Sep 14, 2025
4dcdfdf
Add cancel to batch implementation
WendellAdriel Sep 14, 2025
4050b1a
Refactor
WendellAdriel Sep 14, 2025
b69aa43
Update then and finally hooks to not run if batch is cancelled
WendellAdriel Sep 14, 2025
2a1bc6a
formatting
taylorotwell Sep 15, 2025
ab833f3
formatting
taylorotwell Sep 15, 2025
3a6ce3f
Small fix on handling result
WendellAdriel Sep 16, 2025
9c0347b
Fix issue with progress callback
WendellAdriel Sep 16, 2025
7a0052f
Fix issue with progress callback order
WendellAdriel Sep 16, 2025
65827a3
Merge branch 'feat/http-pool-hooks' of github.com:WendellAdriel/larav…
WendellAdriel Sep 16, 2025
386a626
Removed not used import
WendellAdriel Sep 16, 2025
f6c5f90
Fix Static Analysis and skip cancel test
WendellAdriel Sep 16, 2025
c908e1a
Remove cancel feature from Http::batch
WendellAdriel Sep 24, 2025
0bb9012
Throw exception when adding request to in progress batch
WendellAdriel Sep 24, 2025
c432c1f
Code Review comments
WendellAdriel Sep 25, 2025
109b2bd
formatting
taylorotwell Sep 29, 2025
59a2583
remove inconsistent method
taylorotwell Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Static Analysis and skip cancel test
  • Loading branch information
@WendellAdriel
WendellAdriel committed Sep 16, 2025
commit f6c5f903a8381a5fc5886c5ff89ae30af4a63473
2 changes: 1 addition & 1 deletion src/Illuminate/Http/Client/Batch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ public function send(): array

return $result;
},
'rejected' => function ($reason, $key) use (&$results, $catchCallback) {
'rejected' => function ($reason, $key) use ($catchCallback) {
Copy link
Contributor

@bretto36 bretto36 Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WendellAdriel There is an alert on this line with the use ($catchCallback). Is this used? Looks like it's only using $this->catchCallback and the use statement could be deleted

$this->decrementPendingRequests();

if ($reason instanceof RequestException) {
Expand Down
1 change: 1 addition & 0 deletions tests/Http/HttpClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3826,6 +3826,7 @@ public function testBatchNoCallbacks(): void

public function testBatchCancel(): void
{
$this->markTestSkipped('SKIPPING UNTIL DECISION IS MADE TO KEEP OR REMOVE CANCEL FEATURE');
$this->factory->fake([
'https://200.com' => $this->factory::response('OK', 200),
'https://500.com' => $this->factory::response('Error', 500),
Expand Down