Skip to content

Conversation

@damsien
Copy link

@damsien damsien commented Nov 30, 2025

Summary

This PR fixes the "wrong apiVersion set on the editor" bug by actually checking the storage version of the CRD when getting the BaseObject.

Related Issue

Fixes #4223

Changes

  • Added/Updated [component/file/logic]
  • Fixed [bug/issue/typo]
  • Refactored [code/module] for clarity/performance

Steps to Test

Prerequisites:
Having a CRD that have multiple versions installed on the cluster

Steps to reproduce the bug:

  1. Go to the 'Custom Resources' page of that CRD
  2. Click 'Create' to enter in the editor
  3. See the apiVersion is correctly set to the actual storage version of the CRD

Screenshots (if applicable)

The CRD versions:
Image

The apiVersion automatically set when creating the Custom Resource:
image

Signed-off-by: Damien Dassieu <dassieu.damien@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damsien
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @damsien!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CR editor does not automatically set the storage apiVersion

2 participants