Skip to content

Support for type-hinting shared Page Props #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

Support for type-hinting shared Page Props #2636

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9e86ae
Type-hint shared props
pascalbaljet Oct 16, 2025
ad1f9d6
Update svelte.spec.ts
pascalbaljet Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update svelte.spec.ts
  • Loading branch information
@pascalbaljet
pascalbaljet committed Oct 16, 2025
commit ad1f9d670827cf461495a4940e5a0c2d7cff9a7a
72 changes: 47 additions & 25 deletions tests/svelte.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,44 +13,61 @@ test('props and page store are in sync', async ({ page }) => {
await expect(page.getByText('foo prop is default')).toBeVisible()
await expect(page.getByText('$page.props.foo is default')).toBeVisible()
await expect(page.getByText('pageProps.foo is default')).toBeVisible()
await expect(consoleMessages.messages).toHaveLength(7)
await expect(page.getByText('$sveltePage.props.foo is default')).toBeVisible()
await expect(consoleMessages.messages).toHaveLength(11)
await expect(consoleMessages.messages[0]).toBe('[script] foo prop is default')
await expect(consoleMessages.messages[1]).toBe('[script] $page.props.foo is default')
await expect(consoleMessages.messages[2]).toBe('[reactive expression] foo prop is default')
await expect(consoleMessages.messages[3]).toBe('[reactive expression] $page.props.foo is default')
await expect(consoleMessages.messages[4]).toBe('[onMount] foo prop is default')
await expect(consoleMessages.messages[5]).toBe('[onMount] $page.props.foo is default')
await expect(consoleMessages.messages[6]).toBe('[reactive expression] $page.props.foo is default')
await expect(consoleMessages.messages[2]).toBe('[script] $sveltePage.props.foo is default')
await expect(consoleMessages.messages[3]).toBe('[reactive expression] foo prop is default')
await expect(consoleMessages.messages[4]).toBe('[reactive expression] $page.props.foo is default')
await expect(consoleMessages.messages[5]).toBe('[reactive expression] $sveltePage.props.foo is default')
await expect(consoleMessages.messages[6]).toBe('[onMount] foo prop is default')
await expect(consoleMessages.messages[7]).toBe('[onMount] $page.props.foo is default')
await expect(consoleMessages.messages[8]).toBe('[onMount] $sveltePage.props.foo is default')
await expect(consoleMessages.messages[9]).toBe('[reactive expression] $page.props.foo is default')
await expect(consoleMessages.messages[10]).toBe('[reactive expression] $sveltePage.props.foo is default')
await expect(await page.locator('#input').inputValue()).toEqual('default')

consoleMessages.messages = []
await page.getByRole('link', { name: 'Bar' }).click()

await expect(page.getByText('foo prop is bar')).toBeVisible()
await expect(page.getByText('$page.props.foo is bar')).toBeVisible()
await expect(consoleMessages.messages).toHaveLength(7)
await expect(page.getByText('pageProps.foo is bar')).toBeVisible()
await expect(page.getByText('$sveltePage.props.foo is bar')).toBeVisible()
await expect(consoleMessages.messages).toHaveLength(11)
await expect(consoleMessages.messages[0]).toBe('[reactive expression] $page.props.foo is bar')
await expect(consoleMessages.messages[1]).toBe('[script] foo prop is bar')
await expect(consoleMessages.messages[2]).toBe('[script] $page.props.foo is bar')
await expect(consoleMessages.messages[3]).toBe('[reactive expression] foo prop is bar')
await expect(consoleMessages.messages[4]).toBe('[reactive expression] $page.props.foo is bar')
await expect(consoleMessages.messages[5]).toBe('[onMount] foo prop is bar')
await expect(consoleMessages.messages[6]).toBe('[onMount] $page.props.foo is bar')
await expect(consoleMessages.messages[1]).toBe('[reactive expression] $sveltePage.props.foo is bar')
await expect(consoleMessages.messages[2]).toBe('[script] foo prop is bar')
await expect(consoleMessages.messages[3]).toBe('[script] $page.props.foo is bar')
await expect(consoleMessages.messages[4]).toBe('[script] $sveltePage.props.foo is bar')
await expect(consoleMessages.messages[5]).toBe('[reactive expression] foo prop is bar')
await expect(consoleMessages.messages[6]).toBe('[reactive expression] $page.props.foo is bar')
await expect(consoleMessages.messages[7]).toBe('[reactive expression] $sveltePage.props.foo is bar')
await expect(consoleMessages.messages[8]).toBe('[onMount] foo prop is bar')
await expect(consoleMessages.messages[9]).toBe('[onMount] $page.props.foo is bar')
await expect(consoleMessages.messages[10]).toBe('[onMount] $sveltePage.props.foo is bar')
await expect(await page.locator('#input').inputValue()).toEqual('bar')

consoleMessages.messages = []
await page.getByRole('link', { name: 'Baz' }).click()

await expect(page.getByText('foo prop is baz')).toBeVisible()
await expect(page.getByText('$page.props.foo is baz')).toBeVisible()
await expect(consoleMessages.messages).toHaveLength(7)
await expect(page.getByText('pageProps.foo is baz')).toBeVisible()
await expect(page.getByText('$sveltePage.props.foo is baz')).toBeVisible()
await expect(consoleMessages.messages).toHaveLength(11)
await expect(consoleMessages.messages[0]).toBe('[reactive expression] $page.props.foo is baz')
await expect(consoleMessages.messages[1]).toBe('[script] foo prop is baz')
await expect(consoleMessages.messages[2]).toBe('[script] $page.props.foo is baz')
await expect(consoleMessages.messages[3]).toBe('[reactive expression] foo prop is baz')
await expect(consoleMessages.messages[4]).toBe('[reactive expression] $page.props.foo is baz')
await expect(consoleMessages.messages[5]).toBe('[onMount] foo prop is baz')
await expect(consoleMessages.messages[6]).toBe('[onMount] $page.props.foo is baz')
await expect(consoleMessages.messages[1]).toBe('[reactive expression] $sveltePage.props.foo is baz')
await expect(consoleMessages.messages[2]).toBe('[script] foo prop is baz')
await expect(consoleMessages.messages[3]).toBe('[script] $page.props.foo is baz')
await expect(consoleMessages.messages[4]).toBe('[script] $sveltePage.props.foo is baz')
await expect(consoleMessages.messages[5]).toBe('[reactive expression] foo prop is baz')
await expect(consoleMessages.messages[6]).toBe('[reactive expression] $page.props.foo is baz')
await expect(consoleMessages.messages[7]).toBe('[reactive expression] $sveltePage.props.foo is baz')
await expect(consoleMessages.messages[8]).toBe('[onMount] foo prop is baz')
await expect(consoleMessages.messages[9]).toBe('[onMount] $page.props.foo is baz')
await expect(consoleMessages.messages[10]).toBe('[onMount] $sveltePage.props.foo is baz')
await expect(await page.locator('#input').inputValue()).toEqual('baz')

await page.getByRole('link', { name: 'Home' }).click()
Expand All @@ -62,11 +79,16 @@ test('props and page store are in sync', async ({ page }) => {

await expect(page.getByText('foo prop is baz')).toBeVisible()
await expect(page.getByText('$page.props.foo is baz')).toBeVisible()
await expect(consoleMessages.messages).toHaveLength(6)
await expect(page.getByText('pageProps.foo is baz')).toBeVisible()
await expect(page.getByText('$sveltePage.props.foo is baz')).toBeVisible()
await expect(consoleMessages.messages).toHaveLength(9)
await expect(consoleMessages.messages[0]).toBe('[script] foo prop is baz')
await expect(consoleMessages.messages[1]).toBe('[script] $page.props.foo is baz')
await expect(consoleMessages.messages[2]).toBe('[reactive expression] foo prop is baz')
await expect(consoleMessages.messages[3]).toBe('[reactive expression] $page.props.foo is baz')
await expect(consoleMessages.messages[4]).toBe('[onMount] foo prop is baz')
await expect(consoleMessages.messages[5]).toBe('[onMount] $page.props.foo is baz')
await expect(consoleMessages.messages[2]).toBe('[script] $sveltePage.props.foo is baz')
await expect(consoleMessages.messages[3]).toBe('[reactive expression] foo prop is baz')
await expect(consoleMessages.messages[4]).toBe('[reactive expression] $page.props.foo is baz')
await expect(consoleMessages.messages[5]).toBe('[reactive expression] $sveltePage.props.foo is baz')
await expect(consoleMessages.messages[6]).toBe('[onMount] foo prop is baz')
await expect(consoleMessages.messages[7]).toBe('[onMount] $page.props.foo is baz')
await expect(consoleMessages.messages[8]).toBe('[onMount] $sveltePage.props.foo is baz')
})