add a new no-innerText rule
#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
commented
Jan 26, 2018
| node: node.property, | ||
| message: 'Prefer textContent to innerText', | ||
| fix(fixer) { | ||
| return fixer.replaceText(node.property, 'textContent') |
Contributor
Author
There was a problem hiding this comment.
You can run this on a codebase with --fix and it will fix it! ✨
| type: 'Identifier' | ||
| } | ||
| ], | ||
| output: 'document.querySelector("js-flash-text").textContent = "bar"' |
Contributor
Author
There was a problem hiding this comment.
This will assert the output if this rule was run with --fix.
dgraham
approved these changes
Jan 26, 2018
Contributor
dgraham
left a comment
There was a problem hiding this comment.
As innerText is aware of CSS styling, it will trigger a reflow, whereas textContent will not.
As good a reason as any to prefer textContent.
Contributor
Author
|
I want to merge and publish this but I'm not sure if I have the rights on npm to do that. @josh are you the one that publishes? |
josh
approved these changes
Jan 29, 2018
Contributor
I just added you to our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
textContentseems like a better alternative and we seem to favor that already so if nothing else we can be consistent 😸There are some slight differences between the two and there is probably some code that relies on those differences but there aren't many instances so I can manually check over those to make sure nothing is breaking.
Reading 📚
textContenton MDNinnerTexton MDN