Skip to content

Conversation

@demoasm
Copy link

@demoasm demoasm commented Mar 9, 2023

What type of PR is this?

feat

What this PR does / why we need it (en: English/zh: Chinese):

en: add sample_douyin demo using cloudwego-eco (hertz, kitex and its contribs).
zh:

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2023

CLA assistant check
All committers have signed the CLA.

@GuangmingLuo
Copy link
Member

@demoasm Thanks for your contribution. Please sign CLA and solve CI issues.

@GuangmingLuo
Copy link
Member

@demoasm Please solve the CI issues in lint and compliant. For example, add paths-ignore for kitex_gen folder in .licenserc.yaml file

@demoasm
Copy link
Author

demoasm commented Mar 14, 2023

@GuangmingLuo Hi, I have fixed all lint issues and edited the README.

@GuangmingLuo
Copy link
Member

ERROR the following files don't have a valid license header:
sample_douyin/api_request/api_service/api_service.go
sample_douyin/api_request/api_service/hertz_client.go
sample_douyin/cmd/api/mw/my_jwt.go

@L2ncE
Copy link
Contributor

L2ncE commented Mar 14, 2023

It seems that many places are imitating easy-note. What's the meaning of such biz-demo.

@GuangmingLuo
Copy link
Member

It seems that many places are imitating easy-note. What's the meaning of such biz-demo.

Thanks for pointing it out. For example, when I check the the mw implementation, they seem to be copied from easy-note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants