Skip to content

Conversation

@aeons
Copy link
Contributor

@aeons aeons commented Nov 12, 2024

It looks like size-limit and friends were moved to dependencies by mistake, adding a bunch of transitive dependencies downstream.

This PR moves the dependencies back to devDependencies.

@codesandbox
Copy link

codesandbox bot commented Nov 12, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 9db5448

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@what-the-diff
Copy link

what-the-diff bot commented Nov 12, 2024

PR Summary

  • Dependency Cleaning:

    • We tidied up the key software our project relies on by removing some unnecessary elements (@size-limit/esbuild, @size-limit/esbuild-why, @size-limit/file, and size-limit).
  • Retaining Crucial Software (react-nanny):

    • We ensured the react-nanny software, which is essential to our project, remains in the main section where key dependencies are listed.
  • Relocated Some Dependencies:

    • The software we initially removed was not completely discarded. Instead, we relocated them to the "development dependencies" section, indicating that while they're not needed for the final user version of our product, they're useful for the development process.

@Kysluss Kysluss merged commit d7a8540 into anubra266:main Nov 13, 2024
1 check passed
@Kysluss Kysluss self-requested a review November 13, 2024 23:54
@Kysluss Kysluss added the dependencies Pull requests that update a dependency file label Nov 13, 2024
@Kysluss
Copy link
Collaborator

Kysluss commented Nov 13, 2024

Thank you for the PR and for pointing this out. v5.7.1 is out now fixing this and giving credit to you in the release notes. Thank you for using this project and for your help in maintaining it!

@aeons aeons deleted the fix/dev-dependencies branch November 14, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants