Skip to content

Add support for Opentracing #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2019
Merged

Add support for Opentracing #615

merged 1 commit into from
Jul 5, 2019

Conversation

@Rulox
Copy link
Contributor

@Rulox Rulox commented Jul 4, 2019

Proposed changes

Add OpenTracing support by:

  • Add a new Dockerfile with OpenTracing module for NGINX OSS
  • Add a new Dockerfile with OpenTracing module for NGINX Plus
  • Add 3 new ConfigMap Keys:
    • opentracing
    • opentracing-tracer
    • opentracing-tracer-config
  • Add Documentation regarding how to enable OpenTracing
  • Add a full example of OpenTracing working with the Ingress Controller

Fixes #394

@Rulox Rulox added the enhancement Pull requests for new features/feature enhancements label Jul 4, 2019
@Rulox Rulox requested review from Dean-Coakley and pleshakov July 4, 2019 14:38
@Rulox Rulox self-assigned this Jul 4, 2019
Dean-Coakley
Dean-Coakley approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pleshakov
pleshakov approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit 8986c96 into master Jul 5, 2019
@Rulox Rulox deleted the opentracing branch July 5, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Rulox Rulox

Labels

enhancement Pull requests for new features/feature enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opentracing support

4 participants

@Rulox @pleshakov @Dean-Coakley