Add fail-timeout and max-fails support to vs/vsr #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
suggested changes
Jun 27, 2019
Contributor
pleshakov
left a comment
There was a problem hiding this comment.
please see my comments
1afc2c8 to
2e5f992
Compare
Dean-Coakley
approved these changes
Jun 28, 2019
2e5f992 to
41e32a3
Compare
|
Hey folks, while you are all here, can we also add |
Contributor
|
@komapa |
pleshakov
approved these changes
Jul 1, 2019
Contributor
pleshakov
left a comment
There was a problem hiding this comment.
Looks good.
Please see some small changes requested.
41e32a3 to
e65cea9
Compare
Contributor
|
@Rulox lgtm |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fail-timeoutandmax-failscan be used in Upstreams in VirtualServer and VirtualServerRoutes resources.Also changed the
parseSlowStartfunction to make it more generic asParseTimeexportable function to validate all the times and timeouts of configuration.