client: Change ImageHistory, ImageLoad and ImageSave to use variadic functional options
#49466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
ImageHistory, ImageLoad and ImageSave to use variadic functional options
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
3f69d14 to
b9319f6
Compare
thaJeztah
reviewed
Feb 14, 2025
thaJeztah
reviewed
Feb 14, 2025
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
thaJeztah
approved these changes
Feb 14, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
@crazy-max PTAL
crazy-max
reviewed
Feb 17, 2025
| } | ||
|
|
||
| // ImageAPIClientDeprecated defines deprecated methods of the ImageAPIClient. | ||
| type ImageAPIClientDeprecated interface { |
Member
There was a problem hiding this comment.
@vvoland It seems we should have ImageLoad(ctx context.Context, input io.Reader, quiet bool) in ImageAPIClientDeprecated. Can we add it?
Member
There was a problem hiding this comment.
Ah nevermind we can't duplicate ImageLoad method 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow us being more flexible when adding new functionality to the client and reduce potential breaking changes to the interface in future, change the signatures of
ImageLoad,ImageHistoryandImageSaveto use variadic functional options, to mirror the same approach asImageInspect.Note: We could change all client functions to follow this approach, but currently this PR only does it for functions which already had a signature change in the
master, but weren't released yet.- How to verify it
CI
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)