For open diff editors, resolve the underlying original editor to set … #201597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the appropriate language debugger.
roblourens
reviewed
Dec 29, 2023
| const editorControl = this.editorService.activeTextEditorControl; | ||
| let editorControl = this.editorService.activeTextEditorControl; | ||
| if (isDiffEditor(editorControl)) { | ||
| editorControl = editorControl.getOriginalEditor(); |
Member
There was a problem hiding this comment.
Shouldn't this look at the modified editor? I think I want to debug the one on the right.
Contributor
Author
There was a problem hiding this comment.
That's a good point, I missed the possibility that the user might edit the language for the file, updated.
roblourens
approved these changes
Dec 31, 2023
bpasero
approved these changes
Dec 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the appropriate language debugger.
Resolves #201596
The debug view's welcome state shows an
Open a file which can be debugged or runwhen a supported file is open while in diff view. Instead for diff editors resolve the underlying original editor to allow launching debuggers with resolved language debugger when in diff view.