[12.x] Fixed an issue when calling hasNested with a first relationship of type morphTo.
#56512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue with hasNested fn when the first relation is a morphTo relationship. The `$relation` array was not reset, so we were calling the `has` with a null relation.
hasNested with a first relationship of type morphTo.
added 2 commits
August 1, 2025 11:14
Fixed formatting issue from style-ci.
Fixed formatting issue from style-ci.
hasNested with a first relationship of type morphTo.hasNested with a first relationship of type morphTo.
hasNested with a first relationship of type morphTo.hasNested with a first relationship of type morphTo.
macropay-solutions
pushed a commit
to macropay-solutions/maravel-framework
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the
hasNestedfunction with a string of relationship of which the first one was a morphTo, we had aError: Call to a member function getRelationExistenceQuery() on null.This is because the
$relationsarray, in thehasNestedfunction is passed by reference, but not reset between morph types.The proposed solution is not perfect, but it works fine. I'm open to suggestion as I'm sure it can be a little bit more elegant.
Fixes #56490