Skip to content

Conversation

@janEbert
Copy link
Contributor

@janEbert janEbert commented Sep 18, 2024

This way, we can import the library without requiring a GPU to be present.

What does this PR do?

Do not query the torch.cuda.current_device() upon importing the library. Instead, query it when we actually instantiate the arguments struct.

What issue(s) does this change relate to?

Not submitted.

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

This way, we can import the library without requiring a GPU to be
present.
Copy link
Contributor

@mihir-db mihir-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mihir-db mihir-db merged commit 7b0337f into databricks:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants