GenPlus-GX savestates saved in 2.7 don't work in 2.8.

[webbedspace]

Repro

Here's a zip containing all of the save states and the ROM in question: (Edit: Don't link roms) These load in 2.7 but cause the following error in 2.8:

System.InvalidOperationException: Waterbox Error: Bad hash for state
   at BizHawk.Emulation.Cores.Waterbox.WaterboxHostNative.ReturnData.GetDataOrThrow()
   at BizHawk.Emulation.Cores.Consoles.Sega.gpgx.GPGX.LoadStateBinary(BinaryReader reader)
   at BizHawk.Client.Common.ZipStateLoader.GetLump(BinaryStateLump lump, Boolean abort, Action`2 callback)
   at BizHawk.Client.Common.ZipStateLoader.GetCoreState(Action`1 callbackBinary, Action`1 callbackText)
   at BizHawk.Client.Common.SavestateFile.Load(String path)
   at BizHawk.Client.EmuHawk.MainForm.LoadState(String path, String userFriendlyStateName, Boolean suppressOSD)
   at BizHawk.Client.EmuHawk.MainForm.LoadQuickSave(String quickSlotName, Boolean suppressOSD)
   at BizHawk.Client.EmuHawk.MainForm.CheckHotkey(String trigger)
   at BizHawk.Client.EmuHawk.MainForm.<ProcessInput>b__129_1(Boolean current, String trigger)
   at System.Linq.Enumerable.Aggregate[TSource,TAccumulate](IEnumerable`1 source, TAccumulate seed, Func`3 func)
   at BizHawk.Client.EmuHawk.MainForm.ProcessInput(InputCoalescer hotkeyCoalescer, ControllerInputCoalescer finalHostController, Func`2 searchHotkeyBindings, Func`2 activeControllerHasBinding)
   at BizHawk.Client.EmuHawk.MainForm.ProgramRunLoop()
   at BizHawk.Client.EmuHawk.Program.SubMain(String[] args)

I looked at the release notes for 2.8 but savestate incompatibility wasn't listed among them. If this can't be fixed then I'll understand.

Host env.

• BizHawk 2.7 and 2.8; Windows 10 AMD

[CasualPokePlayer]

The core was changed in 2.8 05f11be

As this is a waterbox core, any core modification invalidates previous savestates.

Also, no BizHawk update guarentees savestate compatiblity. If it works, cool, but don't complain if they don't work in newer versions.

[webbedspace]

Thanks for the quick reply. Still, it'd be nice if guaranteed save state incompatibilities like this were listed in the release notes next time, especially since it's not well-documented which cores are Waterbox and which aren't.

[getCursorsExe]

Maybe someone should add a savestate converter?

[webbedspace]

Maybe someone should add a savestate converter?

Nice thought, but it ain't gonna happen.

[CasualPokePlayer]

Maybe someone should add a savestate converter?

That is impossible for waterbox cores.

[getCursorsExe]

Or perhaps this has to do with the savestate format?

[CasualPokePlayer]

Waterbox core savestates are raw dumps of core memory, including everything from internal state and pointers. How memory is laid out changes with every core update, and you have no idea what's a pointer (which would need to be changed) in this dump, not to mention anything else.

[CasualPokePlayer]

More proper warning message was implemented in ee241dc

[getCursorsExe]

Fixing this would requrie completely rewriting the waterbox, which is not what you want to do.

[Godivctor]

fuck