Loading...
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 | #!/usr/bin/env python3 # Copyright (c) 2018,2020 Intel Corporation # Copyright (c) 2022 Nordic Semiconductor ASA # SPDX-License-Identifier: Apache-2.0 import argparse import collections from email.utils import parseaddr import logging import os from pathlib import Path import re import subprocess import sys import tempfile import traceback import shlex from yamllint import config, linter from junitparser import TestCase, TestSuite, JUnitXml, Skipped, Error, Failure import magic from west.manifest import Manifest from west.manifest import ManifestProject sys.path.insert(0, str(Path(__file__).resolve().parents[1])) from get_maintainer import Maintainers, MaintainersError logger = None def git(*args, cwd=None, ignore_non_zero=False): # Helper for running a Git command. Returns the rstrip()ed stdout output. # Called like git("diff"). Exits with SystemError (raised by sys.exit()) on # errors if 'ignore_non_zero' is set to False (default: False). 'cwd' is the # working directory to use (default: current directory). git_cmd = ("git",) + args try: cp = subprocess.run(git_cmd, capture_output=True, cwd=cwd) except OSError as e: err(f"failed to run '{cmd2str(git_cmd)}': {e}") if not ignore_non_zero and (cp.returncode or cp.stderr): err(f"'{cmd2str(git_cmd)}' exited with status {cp.returncode} and/or " f"wrote to stderr.\n" f"==stdout==\n" f"{cp.stdout.decode('utf-8')}\n" f"==stderr==\n" f"{cp.stderr.decode('utf-8')}\n") return cp.stdout.decode("utf-8").rstrip() def get_shas(refspec): """ Returns the list of Git SHAs for 'refspec'. :param refspec: :return: """ return git('rev-list', f'--max-count={-1 if "." in refspec else 1}', refspec).split() def get_files(filter=None, paths=None): filter_arg = (f'--diff-filter={filter}',) if filter else () paths_arg = ('--', *paths) if paths else () out = git('diff', '--name-only', *filter_arg, COMMIT_RANGE, *paths_arg) files = out.splitlines() for file in list(files): if not os.path.isfile(os.path.join(GIT_TOP, file)): # Drop submodule directories from the list. files.remove(file) return files class FmtdFailure(Failure): def __init__(self, severity, title, file, line=None, col=None, desc=""): self.severity = severity self.title = title self.file = file self.line = line self.col = col self.desc = desc description = f':{desc}' if desc else '' msg_body = desc or title txt = f'\n{title}{description}\nFile:{file}' + \ (f'\nLine:{line}' if line else '') + \ (f'\nColumn:{col}' if col else '') msg = f'{file}' + (f':{line}' if line else '') + f' {msg_body}' typ = severity.lower() super().__init__(msg, typ) self.text = txt class ComplianceTest: """ Base class for tests. Inheriting classes should have a run() method and set these class variables: name: Test name doc: Link to documentation related to what's being tested path_hint: The path the test runs itself in. This is just informative and used in the message that gets printed when running the test. There are two magic strings that can be used instead of a path: - The magic string "<zephyr-base>" can be used to refer to the environment variable ZEPHYR_BASE or, when missing, the calculated base of the zephyr tree - The magic string "<git-top>" refers to the top-level repository directory. This avoids running 'git' to find the top-level directory before main() runs (class variable assignments run when the 'class ...' statement runs). That avoids swallowing errors, because main() reports them to GitHub """ def __init__(self): self.case = TestCase(type(self).name, "Guidelines") # This is necessary because Failure can be subclassed, but since it is # always restored form the element tree, the subclass is lost upon # restoring self.fmtd_failures = [] def _result(self, res, text): res.text = text.rstrip() self.case.result += [res] def error(self, text, msg=None, type_="error"): """ Signals a problem with running the test, with message 'msg'. Raises an exception internally, so you do not need to put a 'return' after error(). """ err = Error(msg or f'{type(self).name} error', type_) self._result(err, text) raise EndTest def skip(self, text, msg=None, type_="skip"): """ Signals that the test should be skipped, with message 'msg'. Raises an exception internally, so you do not need to put a 'return' after skip(). """ skpd = Skipped(msg or f'{type(self).name} skipped', type_) self._result(skpd, text) raise EndTest def failure(self, text, msg=None, type_="failure"): """ Signals that the test failed, with message 'msg'. Can be called many times within the same test to report multiple failures. """ fail = Failure(msg or f'{type(self).name} issues', type_) self._result(fail, text) def fmtd_failure(self, severity, title, file, line=None, col=None, desc=""): """ Signals that the test failed, and store the information in a formatted standardized manner. Can be called many times within the same test to report multiple failures. """ fail = FmtdFailure(severity, title, file, line, col, desc) self._result(fail, fail.text) self.fmtd_failures.append(fail) class EndTest(Exception): """ Raised by ComplianceTest.error()/skip() to end the test. Tests can raise EndTest themselves to immediately end the test, e.g. from within a nested function call. """ class CheckPatch(ComplianceTest): """ Runs checkpatch and reports found issues """ name = "Checkpatch" doc = "See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details." path_hint = "<git-top>" def run(self): checkpatch = os.path.join(ZEPHYR_BASE, 'scripts', 'checkpatch.pl') if not os.path.exists(checkpatch): self.skip(f'{checkpatch} not found') diff = subprocess.Popen(('git', 'diff', COMMIT_RANGE), stdout=subprocess.PIPE, cwd=GIT_TOP) try: subprocess.run((checkpatch, '--mailback', '--no-tree', '-'), check=True, stdin=diff.stdout, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, shell=True, cwd=GIT_TOP) except subprocess.CalledProcessError as ex: output = ex.output.decode("utf-8") regex = r'^\s*\S+:(\d+):\s*(ERROR|WARNING):(.+?):(.+)(?:\n|\r\n?)+' \ r'^\s*#(\d+):\s*FILE:\s*(.+):(\d+):' matches = re.findall(regex, output, re.MULTILINE) for m in matches: self.fmtd_failure(m[1].lower(), m[2], m[5], m[6], col=None, desc=m[3]) # If the regex has not matched add the whole output as a failure if len(matches) == 0: self.failure(output) class DevicetreeBindingsCheck(ComplianceTest): """ Checks if we are introducing any unwanted properties in Devicetree Bindings. """ name = "DevicetreeBindings" doc = "See https://docs.zephyrproject.org/latest/build/dts/bindings.html for more details." path_hint = "<zephyr-base>" def run(self, full=True): dts_bindings = self.parse_dt_bindings() for dts_binding in dts_bindings: self.required_false_check(dts_binding) def parse_dt_bindings(self): """ Returns a list of dts/bindings/**/*.yaml files """ dt_bindings = [] for file_name in get_files(filter="d"): if 'dts/bindings/' in file_name and file_name.endswith('.yaml'): dt_bindings.append(file_name) return dt_bindings def required_false_check(self, dts_binding): with open(dts_binding) as file: line_number = 0 for line in file: line_number += 1 if 'required: false' in line: self.fmtd_failure( 'warning', 'Devicetree Bindings', dts_binding, line_number, col=None, desc="'required: false' is redundant, please remove") class KconfigCheck(ComplianceTest): """ Checks is we are introducing any new warnings/errors with Kconfig, for example using undefined Kconfig variables. """ name = "Kconfig" doc = "See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details." path_hint = "<zephyr-base>" def run(self, full=True, no_modules=False): self.no_modules = no_modules kconf = self.parse_kconfig() self.check_top_menu_not_too_long(kconf) self.check_no_pointless_menuconfigs(kconf) self.check_no_undef_within_kconfig(kconf) self.check_no_redefined_in_defconfig(kconf) self.check_no_enable_in_boolean_prompt(kconf) if full: self.check_no_undef_outside_kconfig(kconf) def get_modules(self, modules_file): """ Get a list of modules and put them in a file that is parsed by Kconfig This is needed to complete Kconfig sanity tests. """ if self.no_modules: with open(modules_file, 'w') as fp_module_file: fp_module_file.write("# Empty\n") return # Invoke the script directly using the Python executable since this is # not a module nor a pip-installed Python utility zephyr_module_path = os.path.join(ZEPHYR_BASE, "scripts", "zephyr_module.py") cmd = [sys.executable, zephyr_module_path, '--kconfig-out', modules_file] try: subprocess.run(cmd, check=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) except subprocess.CalledProcessError as ex: self.error(ex.output.decode("utf-8")) modules_dir = ZEPHYR_BASE + '/modules' modules = [name for name in os.listdir(modules_dir) if os.path.exists(os.path.join(modules_dir, name, 'Kconfig'))] with open(modules_file, 'r') as fp_module_file: content = fp_module_file.read() with open(modules_file, 'w') as fp_module_file: for module in modules: fp_module_file.write("ZEPHYR_{}_KCONFIG = {}\n".format( re.sub('[^a-zA-Z0-9]', '_', module).upper(), modules_dir + '/' + module + '/Kconfig' )) fp_module_file.write(content) def get_kconfig_dts(self, kconfig_dts_file): """ Generate the Kconfig.dts using dts/bindings as the source. This is needed to complete Kconfig compliance tests. """ # Invoke the script directly using the Python executable since this is # not a module nor a pip-installed Python utility zephyr_drv_kconfig_path = os.path.join(ZEPHYR_BASE, "scripts", "dts", "gen_driver_kconfig_dts.py") binding_path = os.path.join(ZEPHYR_BASE, "dts", "bindings") cmd = [sys.executable, zephyr_drv_kconfig_path, '--kconfig-out', kconfig_dts_file, '--bindings-dirs', binding_path] try: subprocess.run(cmd, check=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) except subprocess.CalledProcessError as ex: self.error(ex.output.decode("utf-8")) def parse_kconfig(self): """ Returns a kconfiglib.Kconfig object for the Kconfig files. We reuse this object for all tests to avoid having to reparse for each test. """ # Put the Kconfiglib path first to make sure no local Kconfiglib version is # used kconfig_path = os.path.join(ZEPHYR_BASE, "scripts", "kconfig") if not os.path.exists(kconfig_path): self.error(kconfig_path + " not found") sys.path.insert(0, kconfig_path) # Import globally so that e.g. kconfiglib.Symbol can be referenced in # tests global kconfiglib import kconfiglib # Look up Kconfig files relative to ZEPHYR_BASE os.environ["srctree"] = ZEPHYR_BASE # Parse the entire Kconfig tree, to make sure we see all symbols os.environ["SOC_DIR"] = "soc/" os.environ["ARCH_DIR"] = "arch/" os.environ["BOARD_DIR"] = "boards/*/*" os.environ["ARCH"] = "*" os.environ["KCONFIG_BINARY_DIR"] = tempfile.gettempdir() os.environ['DEVICETREE_CONF'] = "dummy" os.environ['TOOLCHAIN_HAS_NEWLIB'] = "y" # Older name for DEVICETREE_CONF, for compatibility with older Zephyr # versions that don't have the renaming os.environ["GENERATED_DTS_BOARD_CONF"] = "dummy" # For multi repo support self.get_modules(os.path.join(tempfile.gettempdir(), "Kconfig.modules")) # For Kconfig.dts support self.get_kconfig_dts(os.path.join(tempfile.gettempdir(), "Kconfig.dts")) # Tells Kconfiglib to generate warnings for all references to undefined # symbols within Kconfig files os.environ["KCONFIG_WARN_UNDEF"] = "y" try: # Note this will both print warnings to stderr _and_ return # them: so some warnings might get printed # twice. "warn_to_stderr=False" could unfortunately cause # some (other) warnings to never be printed. return kconfiglib.Kconfig() except kconfiglib.KconfigError as e: self.failure(str(e)) raise EndTest def get_defined_syms(self, kconf): # Returns a set() with the names of all defined Kconfig symbols (with no # 'CONFIG_' prefix). This is complicated by samples and tests defining # their own Kconfig trees. For those, just grep for 'config FOO' to find # definitions. Doing it "properly" with Kconfiglib is still useful for # the main tree, because some symbols are defined using preprocessor # macros. # Warning: Needs to work with both --perl-regexp and the 're' module. # (?:...) is a non-capturing group. regex = r"^\s*(?:menu)?config\s*([A-Z0-9_]+)\s*(?:#|$)" # Grep samples/ and tests/ for symbol definitions grep_stdout = git("grep", "-I", "-h", "--perl-regexp", regex, "--", ":samples", ":tests", cwd=ZEPHYR_BASE) # Generate combined list of configs and choices from the main Kconfig tree. kconf_syms = kconf.unique_defined_syms + kconf.unique_choices # Symbols from the main Kconfig tree + grepped definitions from samples # and tests return set([sym.name for sym in kconf_syms] + re.findall(regex, grep_stdout, re.MULTILINE)) def check_top_menu_not_too_long(self, kconf): """ Checks that there aren't too many items in the top-level menu (which might be a sign that stuff accidentally got added there) """ max_top_items = 50 n_top_items = 0 node = kconf.top_node.list while node: # Only count items with prompts. Other items will never be # shown in the menuconfig (outside show-all mode). if node.prompt: n_top_items += 1 node = node.next if n_top_items > max_top_items: self.failure(f""" Expected no more than {max_top_items} potentially visible items (items with prompts) in the top-level Kconfig menu, found {n_top_items} items. If you're deliberately adding new entries, then bump the 'max_top_items' variable in {__file__}.""") def check_no_redefined_in_defconfig(self, kconf): # Checks that no symbols are (re)defined in defconfigs. for node in kconf.node_iter(): # 'kconfiglib' is global # pylint: disable=undefined-variable if "defconfig" in node.filename and (node.prompt or node.help): name = (node.item.name if node.item not in (kconfiglib.MENU, kconfiglib.COMMENT) else str(node)) self.failure(f""" Kconfig node '{name}' found with prompt or help in {node.filename}. Options must not be defined in defconfig files. """) continue def check_no_enable_in_boolean_prompt(self, kconf): # Checks that boolean's prompt does not start with "Enable...". for node in kconf.node_iter(): # skip Kconfig nodes not in-tree (will present an absolute path) if os.path.isabs(node.filename): continue # 'kconfiglib' is global # pylint: disable=undefined-variable # only process boolean symbols with a prompt if (not isinstance(node.item, kconfiglib.Symbol) or node.item.type != kconfiglib.BOOL or not node.prompt or not node.prompt[0]): continue if re.match(r"^[Ee]nable.*", node.prompt[0]): self.failure(f""" Boolean option '{node.item.name}' prompt must not start with 'Enable...'. Please check Kconfig guidelines. """) continue def check_no_pointless_menuconfigs(self, kconf): # Checks that there are no pointless 'menuconfig' symbols without # children in the Kconfig files bad_mconfs = [] for node in kconf.node_iter(): # 'kconfiglib' is global # pylint: disable=undefined-variable # Avoid flagging empty regular menus and choices, in case people do # something with 'osource' (could happen for 'menuconfig' symbols # too, though it's less likely) if node.is_menuconfig and not node.list and \ isinstance(node.item, kconfiglib.Symbol): bad_mconfs.append(node) if bad_mconfs: self.failure("""\ Found pointless 'menuconfig' symbols without children. Use regular 'config' symbols instead. See https://docs.zephyrproject.org/latest/guides/kconfig/tips.html#menuconfig-symbols. """ + "\n".join(f"{node.item.name:35} {node.filename}:{node.linenr}" for node in bad_mconfs)) def check_no_undef_within_kconfig(self, kconf): """ Checks that there are no references to undefined Kconfig symbols within the Kconfig files """ undef_ref_warnings = "\n\n\n".join(warning for warning in kconf.warnings if "undefined symbol" in warning) if undef_ref_warnings: self.failure(f"Undefined Kconfig symbols:\n\n {undef_ref_warnings}") def check_no_undef_outside_kconfig(self, kconf): """ Checks that there are no references to undefined Kconfig symbols outside Kconfig files (any CONFIG_FOO where no FOO symbol exists) """ # Grep for symbol references. # # Example output line for a reference to CONFIG_FOO at line 17 of # foo/bar.c: # # foo/bar.c<null>17<null>#ifdef CONFIG_FOO # # 'git grep --only-matching' would get rid of the surrounding context # ('#ifdef '), but it was added fairly recently (second half of 2018), # so we extract the references from each line ourselves instead. # # The regex uses word boundaries (\b) to isolate the reference, and # negative lookahead to automatically whitelist the following: # # - ##, for token pasting (CONFIG_FOO_##X) # # - $, e.g. for CMake variable expansion (CONFIG_FOO_${VAR}) # # - @, e.g. for CMakes's configure_file() (CONFIG_FOO_@VAR@) # # - {, e.g. for Python scripts ("CONFIG_FOO_{}_BAR".format(...)") # # - *, meant for comments like '#endif /* CONFIG_FOO_* */ defined_syms = self.get_defined_syms(kconf) # Maps each undefined symbol to a list <filename>:<linenr> strings undef_to_locs = collections.defaultdict(list) # Warning: Needs to work with both --perl-regexp and the 're' module regex = r"\bCONFIG_[A-Z0-9_]+\b(?!\s*##|[$@{*])" # Skip doc/releases, which often references removed symbols grep_stdout = git("grep", "--line-number", "-I", "--null", "--perl-regexp", regex, "--", ":!/doc/releases", cwd=Path(GIT_TOP)) # splitlines() supports various line terminators for grep_line in grep_stdout.splitlines(): path, lineno, line = grep_line.split("\0") # Extract symbol references (might be more than one) within the # line for sym_name in re.findall(regex, line): sym_name = sym_name[7:] # Strip CONFIG_ if sym_name not in defined_syms and \ sym_name not in self.UNDEF_KCONFIG_WHITELIST: undef_to_locs[sym_name].append(f"{path}:{lineno}") if not undef_to_locs: return # String that describes all referenced but undefined Kconfig symbols, # in alphabetical order, along with the locations where they're # referenced. Example: # # CONFIG_ALSO_MISSING arch/xtensa/core/fatal.c:273 # CONFIG_MISSING arch/xtensa/core/fatal.c:264, subsys/fb/cfb.c:20 undef_desc = "\n".join(f"CONFIG_{sym_name:35} {', '.join(locs)}" for sym_name, locs in sorted(undef_to_locs.items())) self.failure(f""" Found references to undefined Kconfig symbols. If any of these are false positives, then add them to UNDEF_KCONFIG_WHITELIST in {__file__}. If the reference is for a comment like /* CONFIG_FOO_* */ (or /* CONFIG_FOO_*_... */), then please use exactly that form (with the '*'). The CI check knows not to flag it. More generally, a reference followed by $, @, {{, *, or ## will never be flagged. {undef_desc}""") # Many of these are symbols used as examples. Note that the list is sorted # alphabetically, and skips the CONFIG_ prefix. UNDEF_KCONFIG_WHITELIST = { "ALSO_MISSING", "APP_LINK_WITH_", "APP_LOG_LEVEL", # Application log level is not detected correctly as # the option is defined using a template, so it can't # be grepped "ARMCLANG_STD_LIBC", # The ARMCLANG_STD_LIBC is defined in the # toolchain Kconfig which is sourced based on # Zephyr toolchain variant and therefore not # visible to compliance. "BOOT_ENCRYPTION_KEY_FILE", # Used in sysbuild "BOOT_ENCRYPT_IMAGE", # Used in sysbuild "BINDESC_", # Used in documentation as a prefix "BOOT_UPGRADE_ONLY", # Used in example adjusting MCUboot config, but # symbol is defined in MCUboot itself. "BOOT_SERIAL_BOOT_MODE", # Used in (sysbuild-based) test/ # documentation "BOOT_SERIAL_CDC_ACM", # Used in (sysbuild-based) test "BOOT_SERIAL_ENTRANCE_GPIO", # Used in (sysbuild-based) test "BOOT_SERIAL_IMG_GRP_HASH", # Used in documentation "BOOT_SHARE_DATA", # Used in Kconfig text "BOOT_SHARE_DATA_BOOTINFO", # Used in (sysbuild-based) test "BOOT_SHARE_BACKEND_RETENTION", # Used in Kconfig text "BOOT_SIGNATURE_KEY_FILE", # MCUboot setting used by sysbuild "BOOT_SIGNATURE_TYPE_ECDSA_P256", # MCUboot setting used by sysbuild "BOOT_SIGNATURE_TYPE_ED25519", # MCUboot setting used by sysbuild "BOOT_SIGNATURE_TYPE_NONE", # MCUboot setting used by sysbuild "BOOT_SIGNATURE_TYPE_RSA", # MCUboot setting used by sysbuild "BOOT_VALIDATE_SLOT0", # Used in (sysbuild-based) test "BOOT_WATCHDOG_FEED", # Used in (sysbuild-based) test "BTTESTER_LOG_LEVEL", # Used in tests/bluetooth/tester "BTTESTER_LOG_LEVEL_DBG", # Used in tests/bluetooth/tester "CDC_ACM_PORT_NAME_", "CLOCK_STM32_SYSCLK_SRC_", "CMU", "COMPILER_RT_RTLIB", "BT_6LOWPAN", # Defined in Linux, mentioned in docs "CMD_CACHE", # Defined in U-Boot, mentioned in docs "COUNTER_RTC_STM32_CLOCK_SRC", "CRC", # Used in TI CC13x2 / CC26x2 SDK comment "DEEP_SLEEP", # #defined by RV32M1 in ext/ "DESCRIPTION", "ERR", "ESP_DIF_LIBRARY", # Referenced in CMake comment "EXPERIMENTAL", "FFT", # Used as an example in cmake/extensions.cmake "FLAG", # Used as an example "FOO", "FOO_LOG_LEVEL", "FOO_SETTING_1", "FOO_SETTING_2", "LSM6DSO_INT_PIN", "LIBGCC_RTLIB", "LLVM_USE_LD", # Both LLVM_USE_* are in cmake/toolchain/llvm/Kconfig "LLVM_USE_LLD", # which are only included if LLVM is selected but # not other toolchains. Compliance check would complain, # for example, if you are using GCC. "MCUBOOT_LOG_LEVEL_WRN", # Used in example adjusting MCUboot # config, "MCUBOOT_LOG_LEVEL_INF", "MCUBOOT_DOWNGRADE_PREVENTION", # but symbols are defined in MCUboot # itself. "MCUBOOT_ACTION_HOOKS", # Used in (sysbuild-based) test "MCUBOOT_CLEANUP_ARM_CORE", # Used in (sysbuild-based) test "MCUBOOT_SERIAL", # Used in (sysbuild-based) test/ # documentation "MCUMGR_GRP_EXAMPLE", # Used in documentation "MCUMGR_GRP_EXAMPLE_LOG_LEVEL", # Used in documentation "MCUMGR_GRP_EXAMPLE_OTHER_HOOK", # Used in documentation "MISSING", "MODULES", "MYFEATURE", "MY_DRIVER_0", "NORMAL_SLEEP", # #defined by RV32M1 in ext/ "OPT", "OPT_0", "PEDO_THS_MIN", "REG1", "REG2", "SAMPLE_MODULE_LOG_LEVEL", # Used as an example in samples/subsys/logging "SAMPLE_MODULE_LOG_LEVEL_DBG", # Used in tests/subsys/logging/log_api "LOG_BACKEND_MOCK_OUTPUT_DEFAULT", #Referenced in tests/subsys/logging/log_syst "LOG_BACKEND_MOCK_OUTPUT_SYST", #Referenced in testcase.yaml of log_syst test "SEL", "SHIFT", "SOC_WATCH", # Issue 13749 "SOME_BOOL", "SOME_INT", "SOME_OTHER_BOOL", "SOME_STRING", "SRAM2", # Referenced in a comment in samples/application_development "STACK_SIZE", # Used as an example in the Kconfig docs "STD_CPP", # Referenced in CMake comment "TAGOIO_HTTP_POST_LOG_LEVEL", # Used as in samples/net/cloud/tagoio "TEST1", "TOOLCHAIN_ARCMWDT_SUPPORTS_THREAD_LOCAL_STORAGE", # The symbol is defined in the toolchain # Kconfig which is sourced based on Zephyr # toolchain variant and therefore not visible # to compliance. "TYPE_BOOLEAN", "USB_CONSOLE", "USE_STDC_", "WHATEVER", "EXTRA_FIRMWARE_DIR", # Linux, in boards/xtensa/intel_adsp_cavs25/doc "HUGETLBFS", # Linux, in boards/xtensa/intel_adsp_cavs25/doc "MODVERSIONS", # Linux, in boards/xtensa/intel_adsp_cavs25/doc "SECURITY_LOADPIN", # Linux, in boards/xtensa/intel_adsp_cavs25/doc "ZEPHYR_TRY_MASS_ERASE", # MCUBoot setting described in sysbuild # documentation "ZTEST_FAIL_TEST_", # regex in tests/ztest/fail/CMakeLists.txt } class KconfigBasicCheck(KconfigCheck): """ Checks if we are introducing any new warnings/errors with Kconfig, for example using undefined Kconfig variables. This runs the basic Kconfig test, which is checking only for undefined references inside the Kconfig tree. """ name = "KconfigBasic" doc = "See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details." path_hint = "<zephyr-base>" def run(self): super().run(full=False) class KconfigBasicNoModulesCheck(KconfigCheck): """ Checks if we are introducing any new warnings/errors with Kconfig when no modules are available. Catches symbols used in the main repository but defined only in a module. """ name = "KconfigBasicNoModules" doc = "See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details." path_hint = "<zephyr-base>" def run(self): super().run(full=False, no_modules=True) class Nits(ComplianceTest): """ Checks various nits in added/modified files. Doesn't check stuff that's already covered by e.g. checkpatch.pl and pylint. """ name = "Nits" doc = "See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details." path_hint = "<git-top>" def run(self): # Loop through added/modified files for fname in get_files(filter="d"): if "Kconfig" in fname: self.check_kconfig_header(fname) self.check_redundant_zephyr_source(fname) if fname.startswith("dts/bindings/"): self.check_redundant_document_separator(fname) if fname.endswith((".c", ".conf", ".cpp", ".dts", ".overlay", ".h", ".ld", ".py", ".rst", ".txt", ".yaml", ".yml")) or \ "Kconfig" in fname or \ "defconfig" in fname or \ fname == "README": self.check_source_file(fname) def check_kconfig_header(self, fname): # Checks for a spammy copy-pasted header format with open(os.path.join(GIT_TOP, fname), encoding="utf-8") as f: contents = f.read() # 'Kconfig - yada yada' has a copy-pasted redundant filename at the # top. This probably means all of the header was copy-pasted. if re.match(r"\s*#\s*(K|k)config[\w.-]*\s*-", contents): self.failure(f""" Please use this format for the header in '{fname}' (see https://docs.zephyrproject.org/latest/build/kconfig/tips.html#header-comments-and-other-nits): # <Overview of symbols defined in the file, preferably in plain English> (Blank line) # Copyright (c) 2019 ... # SPDX-License-Identifier: <License> (Blank line) (Kconfig definitions) Skip the "Kconfig - " part of the first line, since it's clear that the comment is about Kconfig from context. The "# Kconfig - " is what triggers this failure. """) def check_redundant_zephyr_source(self, fname): # Checks for 'source "$(ZEPHYR_BASE)/Kconfig[.zephyr]"', which can be # be simplified to 'source "Kconfig[.zephyr]"' with open(os.path.join(GIT_TOP, fname), encoding="utf-8") as f: # Look for e.g. rsource as well, for completeness match = re.search( r'^\s*(?:o|r|or)?source\s*"\$\(?ZEPHYR_BASE\)?/(Kconfig(?:\.zephyr)?)"', f.read(), re.MULTILINE) if match: self.failure(""" Redundant 'source "$(ZEPHYR_BASE)/{0}" in '{1}'. Just do 'source "{0}"' instead. The $srctree environment variable already points to the Zephyr root, and all 'source's are relative to it.""".format(match.group(1), fname)) def check_redundant_document_separator(self, fname): # Looks for redundant '...' document separators in bindings with open(os.path.join(GIT_TOP, fname), encoding="utf-8") as f: if re.search(r"^\.\.\.", f.read(), re.MULTILINE): self.failure(f"""\ Redundant '...' document separator in {fname}. Binding YAML files are never concatenated together, so no document separators are needed.""") def check_source_file(self, fname): # Generic nits related to various source files with open(os.path.join(GIT_TOP, fname), encoding="utf-8") as f: contents = f.read() if not contents.endswith("\n"): self.failure(f"Missing newline at end of '{fname}'. Check your text " f"editor settings.") if contents.startswith("\n"): self.failure(f"Please remove blank lines at start of '{fname}'") if contents.endswith("\n\n"): self.failure(f"Please remove blank lines at end of '{fname}'") class GitDiffCheck(ComplianceTest): """ Checks for conflict markers or whitespace errors with git diff --check """ name = "GitDiffCheck" doc = "Git conflict markers and whitespace errors are not allowed in added changes" path_hint = "<git-top>" def run(self): offending_lines = [] # Use regex to filter out unnecessay output # Reason: `--check` is mutually exclusive with `--name-only` and `-s` p = re.compile(r"\S+\: .*\.") for shaidx in get_shas(COMMIT_RANGE): # Ignore non-zero return status code # Reason: `git diff --check` sets the return code to the number of offending lines diff = git("diff", f"{shaidx}^!", "--check", ignore_non_zero=True) lines = p.findall(diff) lines = map(lambda x: f"{shaidx}: {x}", lines) offending_lines.extend(lines) if len(offending_lines) > 0: self.failure("\n".join(offending_lines)) class GitLint(ComplianceTest): """ Runs gitlint on the commits and finds issues with style and syntax """ name = "Gitlint" doc = "See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details" path_hint = "<git-top>" def run(self): # By default gitlint looks for .gitlint configuration only in # the current directory try: subprocess.run('gitlint --commits ' + COMMIT_RANGE, check=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, shell=True, cwd=GIT_TOP) except subprocess.CalledProcessError as ex: self.failure(ex.output.decode("utf-8")) class PyLint(ComplianceTest): """ Runs pylint on all .py files, with a limited set of checks enabled. The configuration is in the pylintrc file. """ name = "Pylint" doc = "See https://www.pylint.org/ for more details" path_hint = "<git-top>" def run(self): # Path to pylint configuration file pylintrc = os.path.abspath(os.path.join(os.path.dirname(__file__), "pylintrc")) # Path to additional pylint check scripts check_script_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../pylint/checkers")) # List of files added/modified by the commit(s). files = get_files(filter="d") # Filter out everything but Python files. Keep filenames # relative (to GIT_TOP) to stay farther from any command line # limit. py_files = filter_py(GIT_TOP, files) if not py_files: return python_environment = os.environ.copy() if "PYTHONPATH" in python_environment: python_environment["PYTHONPATH"] = check_script_dir + ":" + \ python_environment["PYTHONPATH"] else: python_environment["PYTHONPATH"] = check_script_dir pylintcmd = ["pylint", "--rcfile=" + pylintrc, "--load-plugins=argparse-checker"] + py_files logger.info(cmd2str(pylintcmd)) try: subprocess.run(pylintcmd, check=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, cwd=GIT_TOP, env=python_environment) except subprocess.CalledProcessError as ex: output = ex.output.decode("utf-8") regex = r'^\s*(\S+):(\d+):(\d+):\s*([A-Z]\d{4}):\s*(.*)$' matches = re.findall(regex, output, re.MULTILINE) for m in matches: # https://pylint.pycqa.org/en/latest/user_guide/messages/messages_overview.html# severity = 'unknown' if m[3][0] in ('F', 'E'): severity = 'error' elif m[3][0] in ('W','C', 'R', 'I'): severity = 'warning' self.fmtd_failure(severity, m[3], m[0], m[1], col=m[2], desc=m[4]) # If the regex has not matched add the whole output as a failure if len(matches) == 0: self.failure(output) def filter_py(root, fnames): # PyLint check helper. Returns all Python script filenames among the # filenames in 'fnames', relative to directory 'root'. # # Uses the python-magic library, so that we can detect Python # files that don't end in .py as well. python-magic is a frontend # to libmagic, which is also used by 'file'. return [fname for fname in fnames if (fname.endswith(".py") or magic.from_file(os.path.join(root, fname), mime=True) == "text/x-python")] class Identity(ComplianceTest): """ Checks if Emails of author and signed-off messages are consistent. """ name = "Identity" doc = "See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details" # git rev-list and git log don't depend on the current (sub)directory # unless explicited path_hint = "<git-top>" def run(self): for shaidx in get_shas(COMMIT_RANGE): commit = git("log", "--decorate=short", "-n 1", shaidx) signed = [] author = "" sha = "" parsed_addr = None for line in commit.split("\n"): match = re.search(r"^commit\s([^\s]*)", line) if match: sha = match.group(1) match = re.search(r"^Author:\s(.*)", line) if match: author = match.group(1) parsed_addr = parseaddr(author) match = re.search(r"signed-off-by:\s(.*)", line, re.IGNORECASE) if match: signed.append(match.group(1)) error1 = f"{sha}: author email ({author}) needs to match one of " \ f"the signed-off-by entries." error2 = f"{sha}: author email ({author}) does not follow the " \ f"syntax: First Last <email>." error3 = f"{sha}: author email ({author}) must be a real email " \ f"and cannot end in @users.noreply.github.com" failure = None if author not in signed: failure = error1 if not parsed_addr or len(parsed_addr[0].split(" ")) < 2: if not failure: failure = error2 else: failure = failure + "\n" + error2 elif parsed_addr[1].endswith("@users.noreply.github.com"): failure = error3 if failure: self.failure(failure) class BinaryFiles(ComplianceTest): """ Check that the diff contains no binary files. """ name = "BinaryFiles" doc = "No binary files allowed." path_hint = "<git-top>" def run(self): BINARY_ALLOW_PATHS = ("doc/", "boards/", "samples/") # svg files are always detected as binary, see .gitattributes BINARY_ALLOW_EXT = (".jpg", ".jpeg", ".png", ".svg", ".webp") for stat in git("diff", "--numstat", "--diff-filter=A", COMMIT_RANGE).splitlines(): added, deleted, fname = stat.split("\t") if added == "-" and deleted == "-": if (fname.startswith(BINARY_ALLOW_PATHS) and fname.endswith(BINARY_ALLOW_EXT)): continue self.failure(f"Binary file not allowed: {fname}") class ImageSize(ComplianceTest): """ Check that any added image is limited in size. """ name = "ImageSize" doc = "Check the size of image files." path_hint = "<git-top>" def run(self): SIZE_LIMIT = 250 << 10 BOARD_SIZE_LIMIT = 100 << 10 for file in get_files(filter="d"): full_path = os.path.join(GIT_TOP, file) mime_type = magic.from_file(full_path, mime=True) if not mime_type.startswith("image/"): continue size = os.path.getsize(full_path) limit = SIZE_LIMIT if file.startswith("boards/"): limit = BOARD_SIZE_LIMIT if size > limit: self.failure(f"Image file too large: {file} reduce size to " f"less than {limit >> 10}kB") class MaintainersFormat(ComplianceTest): """ Check that MAINTAINERS file parses correctly. """ name = "MaintainersFormat" doc = "Check that MAINTAINERS file parses correctly." path_hint = "<git-top>" def run(self): MAINTAINERS_FILES = ["MAINTAINERS.yml", "MAINTAINERS.yaml"] for file in MAINTAINERS_FILES: if not os.path.exists(file): continue try: Maintainers(file) except MaintainersError as ex: self.failure(f"Error parsing {file}: {ex}") class ModulesMaintainers(ComplianceTest): """ Check that all modules have a MAINTAINERS entry. """ name = "ModulesMaintainers" doc = "Check that all modules have a MAINTAINERS entry." path_hint = "<git-top>" def run(self): MAINTAINERS_FILES = ["MAINTAINERS.yml", "MAINTAINERS.yaml"] manifest = Manifest.from_file() maintainers_file = None for file in MAINTAINERS_FILES: if os.path.exists(file): maintainers_file = file break if not maintainers_file: return maintainers = Maintainers(maintainers_file) for project in manifest.get_projects([]): if not manifest.is_active(project): continue if isinstance(project, ManifestProject): continue area = f"West project: {project.name}" if area not in maintainers.areas: self.failure(f"Missing {maintainers_file} entry for: \"{area}\"") class YAMLLint(ComplianceTest): """ YAMLLint """ name = "YAMLLint" doc = "Check YAML files with YAMLLint." path_hint = "<git-top>" def run(self): config_file = os.path.join(ZEPHYR_BASE, ".yamllint") for file in get_files(filter="d"): if Path(file).suffix not in ['.yaml', '.yml']: continue yaml_config = config.YamlLintConfig(file=config_file) if file.startswith(".github/"): # Tweak few rules for workflow files. yaml_config.rules["line-length"] = False yaml_config.rules["truthy"]["allowed-values"].extend(['on', 'off']) elif file == ".codecov.yml": yaml_config.rules["truthy"]["allowed-values"].extend(['yes', 'no']) with open(file, 'r') as fp: for p in linter.run(fp, yaml_config): self.fmtd_failure('warning', f'YAMLLint ({p.rule})', file, p.line, col=p.column, desc=p.desc) def init_logs(cli_arg): # Initializes logging global logger level = os.environ.get('LOG_LEVEL', "WARN") console = logging.StreamHandler() console.setFormatter(logging.Formatter('%(levelname)-8s: %(message)s')) logger = logging.getLogger('') logger.addHandler(console) logger.setLevel(cli_arg or level) logger.info("Log init completed, level=%s", logging.getLevelName(logger.getEffectiveLevel())) def inheritors(klass): subclasses = set() work = [klass] while work: parent = work.pop() for child in parent.__subclasses__(): if child not in subclasses: subclasses.add(child) work.append(child) return subclasses def annotate(res): """ https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#about-workflow-commands """ notice = f'::{res.severity} file={res.file}' + \ (f',line={res.line}' if res.line else '') + \ (f',col={res.col}' if res.col else '') + \ f',title={res.title}::{res.message}' print(notice) def resolve_path_hint(hint): if hint == "<zephyr-base>": return ZEPHYR_BASE elif hint == "<git-top>": return GIT_TOP else: return hint def parse_args(argv): default_range = 'HEAD~1..HEAD' parser = argparse.ArgumentParser( description="Check for coding style and documentation warnings.", allow_abbrev=False) parser.add_argument('-c', '--commits', default=default_range, help=f'''Commit range in the form: a..[b], default is {default_range}''') parser.add_argument('-o', '--output', default="compliance.xml", help='''Name of outfile in JUnit format, default is ./compliance.xml''') parser.add_argument('-n', '--no-case-output', action="store_true", help="Do not store the individual test case output.") parser.add_argument('-l', '--list', action="store_true", help="List all checks and exit") parser.add_argument("-v", "--loglevel", choices=['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'], help="python logging level") parser.add_argument('-m', '--module', action="append", default=[], help="Checks to run. All checks by default. (case " \ "insensitive)") parser.add_argument('-e', '--exclude-module', action="append", default=[], help="Do not run the specified checks (case " \ "insensitive)") parser.add_argument('-j', '--previous-run', default=None, help='''Pre-load JUnit results in XML format from a previous run and combine with new results.''') parser.add_argument('--annotate', action="store_true", help="Print GitHub Actions-compatible annotations.") return parser.parse_args(argv) def _main(args): # The "real" main(), which is wrapped to catch exceptions and report them # to GitHub. Returns the number of test failures. global ZEPHYR_BASE ZEPHYR_BASE = os.environ.get('ZEPHYR_BASE') if not ZEPHYR_BASE: # Let the user run this script as ./scripts/ci/check_compliance.py without # making them set ZEPHYR_BASE. ZEPHYR_BASE = str(Path(__file__).resolve().parents[2]) # Propagate this decision to child processes. os.environ['ZEPHYR_BASE'] = ZEPHYR_BASE # The absolute path of the top-level git directory. Initialize it here so # that issues running Git can be reported to GitHub. global GIT_TOP GIT_TOP = git("rev-parse", "--show-toplevel") # The commit range passed in --commit, e.g. "HEAD~3" global COMMIT_RANGE COMMIT_RANGE = args.commits init_logs(args.loglevel) logger.info(f'Running tests on commit range {COMMIT_RANGE}') if args.list: for testcase in inheritors(ComplianceTest): print(testcase.name) return 0 # Load saved test results from an earlier run, if requested if args.previous_run: if not os.path.exists(args.previous_run): # This probably means that an earlier pass had an internal error # (the script is currently run multiple times by the ci-pipelines # repo). Since that earlier pass might've posted an error to # GitHub, avoid generating a GitHub comment here, by avoiding # sys.exit() (which gets caught in main()). print(f"error: '{args.previous_run}' not found", file=sys.stderr) return 1 logging.info(f"Loading previous results from {args.previous_run}") for loaded_suite in JUnitXml.fromfile(args.previous_run): suite = loaded_suite break else: suite = TestSuite("Compliance") included = list(map(lambda x: x.lower(), args.module)) excluded = list(map(lambda x: x.lower(), args.exclude_module)) for testcase in inheritors(ComplianceTest): # "Modules" and "testcases" are the same thing. Better flags would have # been --tests and --exclude-tests or the like, but it's awkward to # change now. if included and testcase.name.lower() not in included: continue if testcase.name.lower() in excluded: print("Skipping " + testcase.name) continue test = testcase() try: print(f"Running {test.name:16} tests in " f"{resolve_path_hint(test.path_hint)} ...") test.run() except EndTest: pass # Annotate if required if args.annotate: for res in test.fmtd_failures: annotate(res) suite.add_testcase(test.case) if args.output: xml = JUnitXml() xml.add_testsuite(suite) xml.update_statistics() xml.write(args.output, pretty=True) failed_cases = [] name2doc = {testcase.name: testcase.doc for testcase in inheritors(ComplianceTest)} for case in suite: if case.result: if case.is_skipped: logging.warning(f"Skipped {case.name}") else: failed_cases.append(case) else: # Some checks like codeowners can produce no .result logging.info(f"No JUnit result for {case.name}") n_fails = len(failed_cases) if n_fails: print(f"{n_fails} checks failed") for case in failed_cases: for res in case.result: errmsg = res.text.strip() logging.error(f"Test {case.name} failed: \n{errmsg}") if args.no_case_output: continue with open(f"{case.name}.txt", "w") as f: docs = name2doc.get(case.name) f.write(f"{docs}\n") for res in case.result: errmsg = res.text.strip() f.write(f'\n {errmsg}') if args.output: print(f"\nComplete results in {args.output}") return n_fails def main(argv=None): args = parse_args(argv) try: # pylint: disable=unused-import from lxml import etree except ImportError: print("\nERROR: Python module lxml not installed, unable to proceed") print("See https://github.com/weiwei/junitparser/issues/99") return 1 try: n_fails = _main(args) except BaseException: # Catch BaseException instead of Exception to include stuff like # SystemExit (raised by sys.exit()) print(f"Python exception in `{__file__}`:\n\n" f"```\n{traceback.format_exc()}\n```") raise sys.exit(n_fails) def cmd2str(cmd): # Formats the command-line arguments in the iterable 'cmd' into a string, # for error messages and the like return " ".join(shlex.quote(word) for word in cmd) def err(msg): cmd = sys.argv[0] # Empty if missing if cmd: cmd += ": " sys.exit(f"{cmd} error: {msg}") if __name__ == "__main__": main(sys.argv[1:]) |