How to delete multiple elements if checkbox is checked using javascript?

Question

So I got this code, I figured out how to delete one element with the checkbox checked but if I try to delete the second div it won't let me? Does anyone have a solution to it?

HTML

<div id="product-space">
            <div id="product"> <input type="checkbox" id="delete-checkbox">
                <p> JVC200123 <br> Acme DISC <br> 1.00 $ <br> Size: 700 MB</p>
            </div>
            <div id="product"> <input type="checkbox" id="delete-checkbox">
                <p> KRK201929 <br> Acme DISC <br> 1.00 $ <br> Size: 700 MB</p>
            </div>
        </div>
<button type="submit" name="button" value="enter" id="button" onclick="removeCheckedCheckboxes()">MASS DELETE</button>

JavaScript

function removeCheckedCheckboxes() {
    var checkBox = document.getElementById("delete-checkbox");
    var box = document.getElementById("product");
    if (checkBox.checked == true) {
        box.style.display = "none";
    }
}

you can use classname for mass delete

Jasmeen Maradeeya
– Jasmeen Maradeeya

2022-02-09 05:28:03 +00:00
Commented Feb 9, 2022 at 5:28 — Jasmeen Maradeeya
– Jasmeen Maradeeya, Commented Feb 9, 2022 at 5:28

Hugo G · Accepted Answer · 2022-02-09 05:31:22Z

The reason your code does not work is because you use the id attribute multiple times with the same value. This is against HTML standards. Also you use getElementById which can only return a single element.

I would suggest using css classes for marking all relevant elements, and using a simple CSS selector for matching all checked boxes.

function removeCheckedCheckboxes() {
  var checked = document.querySelectorAll(".delete-checkbox:checked");
  checked.forEach((elem) => {
    elem.parentElement.style.display = "none";
  })
}

<div id="product-space">
  <div class="product"> <input type="checkbox" class="delete-checkbox">
    <p> JVC200123 <br> Acme DISC <br> 1.00 $ <br> Size: 700 MB</p>
  </div>
  <div class="product"> <input type="checkbox" class="delete-checkbox">
    <p> KRK201929 <br> Acme DISC <br> 1.00 $ <br> Size: 700 MB</p>
  </div>
</div>
<button type="submit" name="button" value="enter" id="deleteButton" onclick="removeCheckedCheckboxes()">MASS DELETE</button>

navylover · Accepted Answer · 2022-02-09 05:26:54Z

0

see the ref:

getElementById will return the first element with the given ID

You could name them as different ids if just want to handle this issue quickly.

answered Feb 9, 2022 at 5:26

navylover

13.9k5 gold badges33 silver badges44 bronze badges

Comments

Nitheesh · Accepted Answer · 2022-02-09 06:16:46Z

0

Document.getElementById() is used to find elements from DOM with matching ID. It returns a single Element object representing the element whose id property matches the specified string. In your case you have multiple elements with same id. So it will always returns the first element while running this script. So your second element remains in visible state always.

So a better approach is to pick the element using class name rather than id, because id is supposed to be unique and class names need not be unique.

Logic

Pick the target elements using the class names. I used same class names product for the container div and delete-checkbox for the check boxes.
On clicking delete button, loop through the elements with class name product.
Find checkbox inside each product element by checking an element with classname delete-checkbox inside each node.
Check the checked status of each checkbox, if checked, hide the box.

Working Fiddle

var boxes = document.querySelectorAll(".product");
function removeCheckedCheckboxes() {
    boxes.forEach((box) => {
        const checkBox = box.querySelector('.delete-checkbox');
        if (checkBox.checked == true) {
            box.style.display = "none";
        }
    })
}

<div id="product-space">
    <div class="product">
        <input type="checkbox" class="delete-checkbox">
        <p> JVC200123 <br> Acme DISC <br> 1.00 $ <br> Size: 700 MB</p>
    </div>
    <div class="product">
        <input type="checkbox" class="delete-checkbox">
        <p> KRK201929 <br> Acme DISC <br> 1.00 $ <br> Size: 700 MB</p>
    </div>
</div>
<button type="submit"
    name="button" value="enter" id="button"
    onclick="removeCheckedCheckboxes()">MASS
    DELETE
</button>

edited Feb 9, 2022 at 6:16

answered Feb 9, 2022 at 5:31

Nitheesh

20.1k3 gold badges28 silver badges52 bronze badges

2 Comments

Viradex Over a year ago

Please edit your post to correct spelling if possible.

Nitheesh Over a year ago

@ArnavThorat Fixed

Nitheesh · Accepted Answer · 2022-02-09 07:14:01Z

the first thing is, both of your items have the same ID, and you must never use the same ID for multiple divs's. When you use document.getElementById, you return only the first object, and you are not exactly deleting the code by clicking in your button. Try get your element by a class or a tagName like those input fields of yours.

function removeCheckedCheckboxes() {
  var list = document.getElementsByTagName('input')
  for (var i = 0; i < list.length; ++i) {
    var product = list[i]
    if (product.checked)
      product.parentElement.hidden = true
  }
}

<div id="product-space">
  <div class="product">
    <input type="checkbox">
    <p> JVC200123 <br> Acme DISC <br> 1.00 $ <br> Size: 700 MB</p>
  </div>
  <div class="product">
    <input type="checkbox">
    <p> KRK201929 <br> Acme DISC <br> 1.00 $ <br> Size: 700 MB</p>
  </div>
</div>
<button
  type="submit"
  name="button"
  value="enter"
  id="button"
  onclick="removeCheckedCheckboxes()">
  MASS DELETE
</button>

https://www.quora.com/Is-it-ever-ok-to-use-the-same-ID-for-multiple-elements-in-HTML-Doesnt-CSS-specificity-make-IDs-more-granular-than-classes-Doesnt-this-violate-the-rules-of-HTML-Is-there-ever-a-reason-to-do-this

Collectives™ on Stack Overflow

How to delete multiple elements if checkbox is checked using javascript?

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related