why my react js button click event not working

Question

I'm learning React.js and confused on the below code:

btnClick(){
    return (
        <div>
            <button onClick={alert("button clicked!")} >Click me</button>
        </div>
    )
}
render(){
    return(
        <div> 
            {this.btnClick()}
        </div>
    )
}

the alert only get prompted after refreshing every time but not when clicking. Why?

Yossi · Accepted Answer · 2019-03-29 16:08:41Z

3

You should write:

<button onClick={() => alert("button clicked!")} >Click me</button>

And

{this.btnClick}

or

{() => this.btnClick()}

answered Mar 29, 2019 at 16:08

Yossi

6,0877 gold badges50 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

reisdev Over a year ago

The second code won't work. The right would be {this.btnClick()}. You need to call the function. Fiddle here

Jeremy Parker · Accepted Answer · 2019-03-29 16:21:43Z

0

{this.btnClick()} is fine but you need to change the alert function to onClick={() => alert("button clicked!")}

answered Mar 29, 2019 at 16:21

Jeremy Parker

4182 gold badges4 silver badges20 bronze badges

Collectives™ on Stack Overflow

why my react js button click event not working

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related