In ReactJs when use onclick fuction with setState, how to pass parameters?

Question

In my case, im using few buttons and when a button is clicked, there should be a change in view. for the view i am using same panel for each button click and the change will be apply on heading of the panel( company name). To change the name I am sending parameter with Onclick method like below.

class View extends Component {
    constructor(props){
        super(props)
        this.state ={
            message: <Content name="ABC"/>
        }
    }

    changeStateMSG(prevStep,props){
        this.setState({
            message:<Content name={this.props.name}/>
        })
    }
    render() { 
        return ( 
            <div className="row">
            <div className="mr-sm-3">
            <div style={{ width: '18rem', marginTop: '20px' }}>

              <Button onClick={() => this.changeStateMSG(this.props.name="XYZ")} variant="secondary" size="lg" block >
                    Omobio
              </Button>

              <div className="mr-sm-9">
                  <p>{this.state.message}</p>
              </div>

.... when i pass parameter like above (this.props.name="XYZ") i am getting error as "TypeError: Cannot add property name, object is not extensible". Hope some can help me

Avoid storing components (Content) in the state.

xadm
– xadm

2019-03-18 07:25:15 +00:00
Commented Mar 18, 2019 at 7:25 — xadm
– xadm, Commented Mar 18, 2019 at 7:25

Maheer Ali · Accepted Answer · 2019-03-18 07:13:14Z

2

You cannot change the props as the react docs says

Props are Read-Only

Whether you declare a component as a function or a class, it must never modify its own props

You should just pass "XYZ". or you can pass a object with this.props with name:'XYZ' using spread operator.

onClick={() => this.changeStateMSG({...this.props,name:"XYZ"})}

And change your function which this

changeStateMSG(prevStep){
        this.setState({
            message:<Content name={prevState.name}/>
        })
    }

If you don't want all the props object inside your function then just pass "XYZ".

onClick={() => this.changeStateMSG("XYZ")}

And change you function to this

changeStateMSG(name){
   this.setState({
            message:<Content name={name}/>
   })
}

edited Mar 18, 2019 at 7:13

answered Mar 18, 2019 at 6:57

Maheer Ali

36.5k8 gold badges53 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

sajini sandareka Over a year ago

Thank You Maheer :D

Jayendra Sharan · Accepted Answer · 2019-03-18 06:59:07Z

0

Have you checked the documentation? I believe the error clearly states that you can not add property to the this.props.

You can pass the arguments just with this statement, like in a normal function execution.

<Button 
  onClick={() => this.changeStateMSG("value_first_argument", "value_ second_argument")}
  variant="secondary"
  size="lg"
  block >
  Omobio
</Button>

And your function definition should look like,

changeStateMSG(prevStep, props){
        this.setState({
            message:<Content name={this.props.name}/>
        })
    }

answered Mar 18, 2019 at 6:59

Jayendra Sharan

1,0186 silver badges10 bronze badges

Comments

tam.dangc · Accepted Answer · 2019-03-18 07:02:17Z

0

Why you have to pass the props.name to changeStateMSG function when you can access it from that function? Just simple call that in changeStateMSG and remove parameters you don't use.

changeStateMSG(){
    this.setState({
        message:<Content name={this.props.name}/>
    })
}

...
onClick={this.changeStateMSG}

answered Mar 18, 2019 at 7:02

tam.dangc

2,0621 gold badge20 silver badges36 bronze badges

Comments

Thanh Ngo · Accepted Answer · 2019-03-18 07:05:01Z

0

Problem is function this.changeStateMSG(this.props.name="XYZ"). Did U pass variable prevStep. U pass like this (this.props.name="XYZ") is wrong way. Should edit:

render() { 
     const prevStep = 1;
     return ( 
        <div className="row">
          <div className="mr-sm-3">
            <div style={{ width: '18rem', marginTop: '20px' }}>

              <Button onClick={() => this.changeStateMSG(prevStep, {name:'XYZ'})}  variant="secondary" size="lg" block >
                    Omobio
              </Button>

answered Mar 18, 2019 at 7:05

Thanh Ngo

3651 gold badge2 silver badges15 bronze badges

Collectives™ on Stack Overflow

In ReactJs when use onclick fuction with setState, how to pass parameters?

4 Answers 4

Props are Read-Only

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related