access variable from outside loop

Question

I know that this is fundamental JS, but I'd like a simple explanation. From what I've read, If i declare an empty variable outside of my loop, the variable inside the loop should be accessible globally? Or am I totally wrong?

I would like to access randAd from outside my for loop.

var mobileAds = [
    "mobile/bb.jpg",
    "mobile/eyeko.jpg",
    "mobile/farfetch.jpg",
    "mobile/fsb.jpg"
];

var randNum = (Math.floor(Math.random() * mobileAds.length));
var randAd;

var i;
for (i = 0; i < mobileAds.length; ++i) {
    randAd = (mobileAds[randNum]);
}

The answer you have marked as accepted creates an array with the same ad repeated 4 times. Did you intend to create an array or a single string variable in randAd? — adiga
– adiga, Commented Nov 18, 2017 at 15:54

chris Frisina · Accepted Answer · 2018-12-11 20:10:02Z

8

If you want to access every element of randAd outside the for loop try like this var randAd = []; to initialize it as an array. You can easily access it after your for loop but If you use it as a simple variable var randAd;then you'll get the last variable always (it overwrites). So initialize it as an array and push every element inside loop before outputting it.

var mobileAds = [
        "mobile/bb.jpg",
        "mobile/eyeko.jpg",
        "mobile/farfetch.jpg",
        "mobile/fsb.jpg"
    ];
    
var randNum = (Math.floor(Math.random() * mobileAds.length));
var randAd = []; // see the change here
    
var i;
for (i = 0; i < mobileAds.length; ++i) {
    randAd.push(mobileAds[randNum]); // push every element here
}
console.log(randAd);

edited Dec 11, 2018 at 20:10

chris Frisina

19.3k24 gold badges91 silver badges173 bronze badges

answered Nov 18, 2017 at 14:41

A l w a y s S u n n y

38.8k9 gold badges68 silver badges120 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Scott Brown Over a year ago

Thank you! push makes sense when storing an array. But originally I was just trying to access a simple variable from outside a function. Is my code correct in that instance?

A l w a y s S u n n y Over a year ago

Yeah it seems Ok.

adiga · Accepted Answer · 2017-11-18 14:54:53Z

3

You are overthinking. You have done the hard bit in getting a random number between 0 and array's length. So, just get the ad at that index:

var randAd = mobileAds[randNum];

No need to use for loop at all.

answered Nov 18, 2017 at 14:54

adiga

35.4k9 gold badges65 silver badges88 bronze badges

Comments

Aaqib · Accepted Answer · 2017-11-18 14:41:49Z

2

If you would like to use randAd it should be initialised as an empty array [] and then push in that array from inside your loop randAd.push(). Like this:

var randAd=[];

var i;
for (i = 0; i < mobileAds.length; ++i) {
    randAd.push(mobileAds[randNum]);
}

answered Nov 18, 2017 at 14:41

Aaqib

10.4k4 gold badges24 silver badges32 bronze badges

Collectives™ on Stack Overflow

access variable from outside loop

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related