React onClick handler in map function

Question

I've been searching the web for answers to my question, but without success. I am trying to add a simple react click handler to my button, but I can't seem to make it work. It is probably something really simple, I just can't wrap my head around it.

Here is my code:

 export default class ReviewBox extends Component {

 deleteReview() {
  console.log("hey");
 }

 render() {
  const {reviews, date, lectureId} = this.props;
  const that = this;
    return (
      <div className="container content-sm">

        <div className="headline"><h2>Reviews</h2> <span>{date}</span></div>
          <div className="row margin-bottom-20">

            {reviews.map(review => {
                return(
                  <div className="col-md-3 col-sm-6">
                    <div className="thumbnails thumbnail-style thumbnail-kenburn">
                      <div className="caption">
                        <h3>{review.comment}</h3> <br />
                        <button className="btn btn-danger" onClick={this.deleteReview()}>Delete</button>
                      </div>
                    </div>
                  </div>
                )
            })}

          </div>

          <hr />
          <AddReview lectureId={lectureId} />

      </div>
    )
  }
}

It refuses to fire the function when I click a button. I've tried with .bind(this) and onClick={() => this.deleteReview} etc.

All help appreciated!

You should pass to onClick reference to function onClick={ this.deleteReview } - remove () after function name — Oleksandr T.
– Oleksandr T., Commented Nov 22, 2016 at 10:50

duwalanise · Accepted Answer · 2016-11-22 11:33:27Z

7

I think you are missing braces () in arrow function

<button className="btn btn-danger" onClick={() => this.deleteReview()}>Delete</button>

answered Nov 22, 2016 at 11:33

duwalanise

1,3021 gold badge14 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Liju Kuriakose · Accepted Answer · 2016-11-22 11:09:31Z

i think this will help you.....

export default class ReviewBox extends Component {

 deleteReview() {
  console.log("hey");
 },

 render() {
  const {reviews, date, lectureId} = this.props;
  const that = this;
    return (
      <div className="container content-sm">

        <div className="headline"><h2>Reviews</h2> <span>{date}</span></div>
          <div className="row margin-bottom-20">

            {reviews.map(review => {
                return(
                  <div className="col-md-3 col-sm-6">
                    <div className="thumbnails thumbnail-style thumbnail-kenburn">
                      <div className="caption">
                        <h3>{review.comment}</h3> <br />
                        <button className="btn btn-danger" onClick={this.deleteReview}>Delete</button>
                      </div>
                    </div>
                  </div>
                )
            })}

          </div>

          <hr />
          <AddReview lectureId={lectureId} />

      </div>
    )
  }
}

sphinks · Accepted Answer · 2016-11-22 12:43:57Z

0

Removing () from the onClick function call and using { this.deleteReview } will indeed fire up the method, but if you need to bind this as well inside that method, go with @duwalanise answer.

edited Nov 22, 2016 at 12:43

sphinks

3,1289 gold badges42 silver badges55 bronze badges

answered Nov 22, 2016 at 11:48

Gaurab Kc

8519 silver badges9 bronze badges

Comments

Mathias Lund · Accepted Answer · 2016-11-22 13:07:08Z

0

Ah, now I understand. It is because I am rendering the react on serverside, that's why the click handler doesn't work.

I will have to render the JS on the client, in order for it to work :)

answered Nov 22, 2016 at 13:07

Mathias Lund

7722 gold badges9 silver badges24 bronze badges

Collectives™ on Stack Overflow

React onClick handler in map function

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related