How to pass parameters in onClick event bind?

Question

I've set up an onClick event in a ListItem. Then called .bind on the method invoked to pass in the clicked list item's id and name values.

The following SO question suggested using bind but it seems adding the onCLick event to the ListItem breaks the list binding.

Before adding the click event the list span binding to the asset.name is working as expected and the list is populated.

Also if I try onClick={this._onAssetSelected() with no parameters the click event doesn't work.

Question:

How can you pass parameters in an onClick event bind in JSX?

List definition:

                <List selectable={true} selected={0}>  
                {

                    this.state.data.map(function (asset) {
                        return (
                            <ListItem justify="between" onClick={this._onAssetSelected.bind(this, asset.name, asset.id)} >
                                <span>{asset.name}</span>
                            </ListItem>
                        );
                    })

                }
                </List>

Method called from the click event:

   _onAssetSelected(assetName, assetID) {

    console.log(assetName);  
    console.log(assetID);    


    }

Pranesh Ravi · Accepted Answer · 2016-09-27 11:37:57Z

2

You can do this. Define an anonymous function as the callback, inside which you call your method with the parameters. Hop ut helps!

<List
  selectable={true}
  selected={0}>  
  {

    this.state.data.map(function (asset) {
        return (
            <ListItem
              justify="between"
              onClick={(e) => this._onAssetSelected(asset.name, asset.id, e)} >
                <span>{asset.name}</span>
            </ListItem>
        );
    })

  }
</List>

answered Sep 27, 2016 at 11:37

Pranesh Ravi

19.2k10 gold badges51 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

gor181 Over a year ago

Using typical closures is the way to go. I would also pass complete asset object rather than specific properties.

Brian Var Over a year ago

So I defined an anonymous function as above. The console in dev tools tells me Uncaught TypeError: Cannot read property '_onAssetSelected' of undefined I can see that this method is defined in the class. Or am I missing something else here?

Pranesh Ravi Over a year ago

You should add var _this = this before the return in render and use _this._onAssetSelected inside the map.

Brian Var Over a year ago

Ok that works! why do I need to declare a var for _this Instead of just using .this?

Pranesh Ravi Over a year ago

That's because the this inside the map will have the context of the map function. But, your callback is in the React's context which is outside the map. So you need to use the exterior context to call your callback. That's why you need to copy the React's context to _this and use it inside map. I'm replying to the comment via my mobile, so, excuse the formatting. And consider approving the answer.

Collectives™ on Stack Overflow

How to pass parameters in onClick event bind?

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related