Annoying exception in asp.net

Question

everybody; I have this problem in asp.net, I have a page where I insert and modify data, before saving I make a validation if it passes I save the data but if not I raise an exception and show it, the function goes like this;

protected void btnSave_Click(object sender, EventArgs e)
{
try
{
...
if(ValidData())
  //Save
  ...
else
  throw new Exception("Invalid data");
}
catch(Exception ex)
{
  // Javascript alert
  JSLiteral.Text = Utilities.JSAlert(ex.Message);
}
}

The problem is that after I raise the exception and fix the data in the page I click again the save button and it saves but before it shows me again the exception message and its annoying. Even when the data is saved I click again and it shows the message from the exception again.

Do you know the answer for this issue?

JoshBerke · Accepted Answer · 2008-12-03 18:36:28Z

1

If JSLiteral is a server side control and it's using view state. Then you'd need to clear the state of the control, when the save is succesful.

You could disable the viewstate for the control like JSLiteral.EnableViewState =false;

answered Dec 3, 2008 at 18:36

JoshBerke

67.3k25 gold badges131 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Greg Hurlman · Accepted Answer · 2008-12-03 18:32:23Z

1

Are you resetting the value of JSLiteral to empty after you save?

answered Dec 3, 2008 at 18:32

Greg Hurlman

17.8k6 gold badges56 silver badges87 bronze badges

Comments

John MacIntyre · Accepted Answer · 2008-12-03 18:32:24Z

1

Turn off viewstate for your JSLiteral control.

answered Dec 3, 2008 at 18:32

John MacIntyre

13.1k13 gold badges70 silver badges108 bronze badges

Comments

nickd · Accepted Answer · 2008-12-03 18:32:15Z

0

Is the message saved in the viewstate of the literal?

Explicitly set the literal text to nothing if the data is valid.

answered Dec 3, 2008 at 18:32

nickd

4,0712 gold badges22 silver badges26 bronze badges

Comments

Jon · Accepted Answer · 2008-12-03 18:32:24Z

0

My initial guess is that ViewState remembers the error message. Try disabling ViewState on the JSLiteral control.

answered Dec 3, 2008 at 18:32

Jon

1,51815 silver badges24 bronze badges

Comments

James Curran · Accepted Answer · 2008-12-03 18:36:27Z

0

Throwing & catching an exception in the same function is basically pointless (exception are intended to go across call levels). Everything would probably be better if you wrote it as:

if(ValidData())
{
  //Save
}
 else
{  // Javascript alert
  JSLiteral.Text = Utilities.JSAlert(ex.Message);
}

answered Dec 3, 2008 at 18:36

James Curran

104k37 gold badges186 silver badges264 bronze badges

2 Comments

nickd Over a year ago

This is true, but to address the question you also need a JSLiteral.Text = "" in there.

Nelson Miranda Over a year ago

Also when an exception comes from the database it must be catched somewhere and the problem persists.

Collectives™ on Stack Overflow

Annoying exception in asp.net

6 Answers 6

Comments

Comments

Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related