Hyperlinks onclick function not working

Question

I need to handle a onlick function on hyperlinks but its not working..

HTML Code:-

<a href="#" onclick="updateParent()" id="2" value="2">CLICK HERE</a>

Jquery:-

$(document).ready(function(){

    function updateParent(control) {
                    alert('Hi')
                }

})

http://jsfiddle.net/sbnBy/1/

Since you are using jquery anyway... Why don't you use the .click() event? --> api.jquery.com/click — Josef E.
– Josef E., Commented May 9, 2014 at 15:33

gen_Eric · Accepted Answer · 2014-05-09 15:41:07Z

6

updateParent only exists inside the .ready() function. It needs to be global for onclick to work.

Also, you shouldn't be using inline events. You have jQuery, use that.

<a href="#" id="2" value="2">CLICK HERE</a>

<script>
    $(document).ready(function(){
        $('#2').click(function(e){
            // preventDefault... it prevents the "default" action of the tag
            // In this case, it would try to nagivate to `#`.  Which would
            // scroll the page to the top.
            e.preventDefault();

            alert('hi');
        });
    });
</script>

edited May 9, 2014 at 15:41

answered May 9, 2014 at 15:33

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Alex KeySmith Over a year ago

Good answer, perhaps add the purpose behind e.PreventDefault() as the person asking the question looks new to jQuery.

gen_Eric Over a year ago

@AlexKey: I added a comment in the code block. How's that? :-)

Amit Joki · Accepted Answer · 2014-05-09 15:38:28Z

2

The function should be in global scope for onclick to work.

Remove everything except the function:

function updateParent(control) {
  alert('Hi')
}

But the above would still not work as JsFiddle creates a closure.

So the final solution would be just:

window.updateParent = function(control){
   alert("hi");
}

Also you don't need inline js. Use

$(document).ready(function(){
    $('#2').click(function(e){
        e.preventDefault(); // prevent the default action such as redirecting.
        alert('hi');
    });
});

Also you can change the jsfiddle option to use wrap in head

edited May 9, 2014 at 15:38

answered May 9, 2014 at 15:33

Amit Joki

59.4k7 gold badges80 silver badges96 bronze badges

1 Comment

gen_Eric Over a year ago

You can change jsFiddle's settings. Just change onload to no wrap, <head>.

Collectives™ on Stack Overflow

Hyperlinks onclick function not working

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related