Get variable from loop

Question

I have a loop which is creating table:

for(m=1; m<7; m++){

    document.getElementById('content').innerHTML += 
        ('<tr>' +
            '<td>' + m + '</td>' + 
            '<td><input type="checkbox" id="switch'+m+'"><label class="switch" for="switch'+m+'">Button ' + m + '</label></td>' +
        '</tr>')
}

In every row in second TD is button which must be assigned to every row. Each button has his own row. I want to alert m from the first TD exactly when i click button from that row. I mean if i will click button is switch2 i will get alert from m "2". Here is the button code i tried:

var buttons = "#switch" + m

$(function() {
    $(buttons).button();
    $(buttons).click(function(){                        
        alert(m);                                   
    });
});

This is not working because all of the buttons alerting last value from loop = 6. I know it is confused but i hope you uderstand. Really appreciate your help

possible duplicate of Javascript closure inside loops - simple practical example — Felix Kling
– Felix Kling, Commented Apr 1, 2014 at 15:47

Hogan · Accepted Answer · 2014-04-01 14:59:45Z

1

Change it to this:

$(function() {
    var localM = m;
    $(buttons).button();
    $(buttons).click(function(){                        
        alert(localM);                                   
    });
});

The problem is the alert binds to the variable m not the value of m. By allocating a local variable inside the closure you capture the value of m at that point in the loop.

answered Apr 1, 2014 at 14:59

Hogan

70.7k10 gold badges83 silver badges119 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Girish · Accepted Answer · 2014-04-01 14:59:53Z

0

you can also bind event another way, for sample

$("tr > td > input[type=checkbox]").function(e){                        
        alert(event.target.id);                                   
        //OR
        alert(this.id);                                   
});

if you can add any class attribute in element

Then this is safe

 $("tr > td > input[type=checkbox].switch").function(){                        
        alert(event.target.id);                                   
    });

answered Apr 1, 2014 at 14:59

Girish

12.1k3 gold badges37 silver badges54 bronze badges

Comments

Latheesan · Accepted Answer · 2014-04-01 15:02:47Z

There is so many ways to do this. Here's one:

<script type="text/javascript" src="http://code.jquery.com/jquery-1.11.0.min.js"></script>
<script type="text/javascript">

$(document).ready(function()
{
    // Populate Form
    for (var m = 1; m <= 7; m++)
    {
        $('#content').append('<tr>' +
            '<td>' + m + '</td>' + 
            '<td><input type="checkbox" class="clickMe" id="switch'+m+'"><label class="switch" for="switch'+m+'">Button ' + m + '</label></td>' +
        '</tr>');
    }

    // Handle Click
    $('.clickMe').click(function()
    {
        alert('You clicked on : ' + $(this).attr('id')); // alerts "switchN" e.g. switch1

        // or //

        alert('You clicked on : ' + $(this).attr('id').replace('switch', '')); // // alerts "N" e.g. 1
    });

});

</script>

<table id="content"></table>

jmar777 · Accepted Answer · 2014-04-01 15:03:48Z

0

Here's a bit of a refactor (minus the button() plugin):

var $content = $('#content');
for (var m = 1; m < 7; m++) {
    $content.append(
        '<tr>' +
            '<td>' + m + '</td>' +
            '<td>' +
                '<input type="checkbox" id="switch' + m + '">' +
                '<label class="switch" data-num=' + m + ' for="switch' + m +'">Button ' + m + '</label>' +
            '</td>' +
        '</tr>'
    );
}

$('label.switch').click(function(e) {
    e.preventDefault();
    alert($(this).data('num'));
});

JSFIDDLE

answered Apr 1, 2014 at 15:03

jmar777

39.8k11 gold badges68 silver badges66 bronze badges

Collectives™ on Stack Overflow

Get variable from loop

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related