jQuery .on("click"...) with dynamically created elements not working

Question

So I am having some troubling results with jQuery ".on" function and a dynamically created element, the code I am using is this:

this is called in a function sometime random during runtime:

$(".activity-feed").append('<div class="feed-story big-feed-story feed-story-comment multiline-feed-story">\
        <div class="photo-view inbox-size photo-view-rounded-corners">\
            <div class="comment-icon">\
            </div>\
        </div>\
        <div class="comment-content">\
            <div class="delete ucomment-delete click-target" id="ucomment-'+uqid+'" tabindex="-1" style="outline:none;"></div>\
            <span class="feed-story-creator"><a href="/user/'+uid+'/'+username+'">'+username+'</a>&nbsp;</span>\
                <span class="comment-text">\
                    <span>\
                        <span style="white-space: pre-wrap;">'+$(".comment-box").html()+'</span>\
                    </span>\
                </span>\
            <div>\
                <span class="feed-story-footer"><span class="story-timestamp-view">'+time+'</span></span>\
            </div>\
        </div>\
    </div>');

and then this function should allow for comment deletion (its defined at the bottom of the page, not after document ready)

$(".delete").on("click", function() {
    alert('test....');
});

however, I click on the "ucomment-delete" button, and nothing happens :(, however if I click the comments that were there on load, it works
Why is this? What am I doing wrong?

Arun Killu · Accepted Answer · 2013-07-26 04:16:55Z

10

try event delegation

$(document).on("click", ".delete", function() {
 alert();
});

answered Jul 26, 2013 at 4:16

Arun Killu

14.3k5 gold badges38 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Goulash Over a year ago

that works for the dynamically created comments, however it's stopped working for the staticly created comments (they're outputted by php before load) :/

Goulash Over a year ago

i've put it in $(document).ready(function() { .. }); but i still have the same problem

Goulash Over a year ago

oh, that was because i had another function suppressing it on the static comments, oops. :P all good now :) thanks so much

John Koerner · Accepted Answer · 2013-07-26 04:23:32Z

1

You need to bind it to an element that already exists on the page and then can specify a selector for elements that may not yet exist on the page:

$(".activity-feed").on("click",".delete", function() {
    alert('test....');
});

See this fiddle for an example:

http://jsfiddle.net/G4MGZ/

answered Jul 26, 2013 at 4:23

John Koerner

38.2k8 gold badges92 silver badges142 bronze badges

Comments

coolguy · Accepted Answer · 2013-07-26 04:18:50Z

0

if on is not working then your jquery version is older try delegate

$('body').delegate('.delete','click',function(){
 //stuff  
});

answered Jul 26, 2013 at 4:18

coolguy

7,9549 gold badges48 silver badges72 bronze badges

Comments

coolguy · Accepted Answer · 2013-09-09 03:17:45Z

0

The .on() HAS to be wrapped in a document.ready(), even if it's at the end of the file. And I think what @John Koemer says is true, too.

edited Sep 9, 2013 at 3:17

coolguy

7,9549 gold badges48 silver badges72 bronze badges

answered Jul 26, 2013 at 4:38

Ringo

5,5333 gold badges35 silver badges52 bronze badges

Collectives™ on Stack Overflow

jQuery .on("click"...) with dynamically created elements not working

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related