PHP upload issue with code

Question

I keep getting the invalid file error. Can anyone see what is wrong with this script please. I got it from w3 schools and the folder "pics/2012/Blackhall Primary/" does exist

<?php

    if ((($_FILES["file"]["type"] == "image/gif")
    || ($_FILES["file"]["type"] == "image/jpeg")
    || ($_FILES["file"]["type"] == "image/png")
    || ($_FILES["file"]["type"] == "image/jpg")
    || ($_FILES["file"]["type"] == "image/pjpeg"))
    && ($_FILES["file"]["size"] < 20000))
      {
      if ($_FILES["file"]["error"] > 0)
        {
        echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
        }
      else
        {
        echo "Upload: " . $_FILES["file"]["name"] . "<br />";
        echo "Type: " . $_FILES["file"]["type"] . "<br />";
        echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
        echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";

        if (file_exists("pics/2012/Blackhall Primary/" . $_FILES["file"]["name"]))
          {
          echo $_FILES["file"]["name"] . " already exists. ";
          }
        else
          {
          move_uploaded_file($_FILES["file"]["tmp_name"],
          "pics/2012/Blackhall Primary/" . $_FILES["file"]["name"]);
          echo "Stored in: " . "pics/2012/Blackhall Primary/" . $_FILES["file"]["name"];
          }
        }
      }
    else
      {
      echo "Invalid file";
      }
    ?>

1. Are you sure you're not exceeding the filesize? 2. Do you have write permissions for the upload folder? — BBog
– BBog, Commented Jun 29, 2012 at 15:12
W3Schools is erroneous in various places...w3fools.com 9Since you mentioned that you got the above script from there... — verisimilitude
– verisimilitude, Commented Jun 29, 2012 at 15:13
You should also read this: stackoverflow.com/questions/11061355/… — deceze
– deceze ♦, Commented Jun 29, 2012 at 15:47
start with print_r($_FILES); at the top of your script to see what the data is. — Waygood
– Waygood, Commented Jun 29, 2012 at 15:49

Waygood · Accepted Answer · 2012-06-29 15:59:17Z

1

include more error checking like this:

<?php

echo process_files();

function process_files()
{
    $allowed_file_types=array('image/gif','image/jpeg','image/png','image/jpg','image/pjpeg');

    if(0==sizeof($_FILES)) return 'no files uploaded';

    if(!stristr($_FILES['file']['type'], 'image')) return 'file is not an image';

    if(!in_array($_FILES['file']['type'], $allowed_file_types)) return 'image type '.$_FILES['file']['type'].' is not allowed';

    if($_FILES['file']['size'] < 20000) return 'file size too large. Max:20000, File:'.$_FILES['file']['size'];

    // rest of your code here!
}

?>

answered Jun 29, 2012 at 15:59

Waygood

2,6832 gold badges17 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

luchopintado · Accepted Answer · 2012-06-29 17:13:56Z

0

check the extension of your pics, maybe are in uppercase

answered Jun 29, 2012 at 17:13

luchopintado

93911 silver badges15 bronze badges

Collectives™ on Stack Overflow

PHP upload issue with code

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related