Address review comments

Author: Girgias

Zend/tests/offsets/appending_containers.phpt

@@ -6,6 +6,7 @@ Appending containers
 require_once __DIR__ . DIRECTORY_SEPARATOR . 'test_offset_helpers.inc';
 
 foreach ($containers as $container) {
+    echo zend_test_var_export($container), " container:\n";
     try {
         $container[] = 'value';
         var_dump($container);
@@ -16,40 +17,54 @@ foreach ($containers as $container) {
 
 ?>
 --EXPECTF--
+NULL container:
 array(1) {
   [0]=>
   string(5) "value"
 }
+false container:
 
 Deprecated: Automatic conversion of false to array is deprecated in %s on line %d
 array(1) {
   [0]=>
   string(5) "value"
 }
+true container:
 Cannot use a scalar value as an array
+4 container:
 Cannot use a scalar value as an array
+5.5 container:
 Cannot use a scalar value as an array
+'10' container:
 [] operator not supported for strings
+'25.5' container:
 [] operator not supported for strings
+'string' container:
 [] operator not supported for strings
+[] container:
 array(1) {
   [0]=>
   string(5) "value"
 }
+STDERR container:
 Cannot use a scalar value as an array
+new stdClass() container:
 Cannot use object of type stdClass as array
+new ArrayObject() container:
 object(ArrayObject)#2 (1) {
   ["storage":"ArrayObject":private]=>
   array(1) {
     [0]=>
     string(5) "value"
   }
 }
+new A() container:
 string(12) "A::offsetSet"
 NULL
 string(5) "value"
 object(A)#3 (0) {
 }
+new B() container:
 string(12) "B::offsetSet"
 NULL
 string(5) "value"

Zend/tests/offsets/appending_containers_in_read.phpt renamed to Zend/tests/offsets/appending_containers_in_fetch.phpt

@@ -1,11 +1,12 @@
 --TEST--
-Appending containers via a read operation $c[][5] = $v;
+Appending containers via a fetch operation $c[][5] = $v;
 --FILE--
 <?php
 
 require_once __DIR__ . DIRECTORY_SEPARATOR . 'test_offset_helpers.inc';
 
 foreach ($containers as $container) {
+    echo zend_test_var_export($container), " container:\n";
     try {
         $container[][5] = 'value';
         var_dump($container);
@@ -16,13 +17,15 @@ foreach ($containers as $container) {
 
 ?>
 --EXPECTF--
+NULL container:
 array(1) {
   [0]=>
   array(1) {
     [5]=>
     string(5) "value"
   }
 }
+false container:
 
 Deprecated: Automatic conversion of false to array is deprecated in %s on line %d
 array(1) {
@@ -32,28 +35,39 @@ array(1) {
     string(5) "value"
   }
 }
+true container:
 Error: Cannot use a scalar value as an array
+4 container:
 Error: Cannot use a scalar value as an array
+5.5 container:
 Error: Cannot use a scalar value as an array
+'10' container:
 Error: [] operator not supported for strings
+'25.5' container:
 Error: [] operator not supported for strings
+'string' container:
 Error: [] operator not supported for strings
+[] container:
 array(1) {
   [0]=>
   array(1) {
     [5]=>
     string(5) "value"
   }
 }
+STDERR container:
 Error: Cannot use a scalar value as an array
+new stdClass() container:
 Error: Cannot use object of type stdClass as array
+new ArrayObject() container:
 
 Notice: Indirect modification of overloaded element of ArrayObject has no effect in %s on line %d
 object(ArrayObject)#2 (1) {
   ["storage":"ArrayObject":private]=>
   array(0) {
   }
 }
+new A() container:
 string(12) "A::offsetGet"
 NULL
 
@@ -62,6 +76,7 @@ Notice: Indirect modification of overloaded element of A has no effect in %s on
 Warning: Only the first byte will be assigned to the string offset in %s on line %d
 object(A)#3 (0) {
 }
+new B() container:
 
 Notice: Indirect modification of overloaded element of B has no effect in %s on line %d
 ArgumentCountError: B::offsetGet(): Argument #1 ($offset) not passed