Merge pull request #273740 from microsoft/tyriar/273193

Tyriar · web-flow · commit d63892fb1b4d · 2025-10-28T06:03:36.000-07:00
Use offset not client height for determining widget height
diff --git a/src/vs/platform/hover/browser/hoverWidget.ts b/src/vs/platform/hover/browser/hoverWidget.ts
@@ -553,7 +553,7 @@ export class HoverWidget extends Widget implements IHoverWidget {
 		// Position hover below the target
 		else if (this._hoverPosition === HoverPosition.BELOW) {
 			// Hover on bottom is going beyond window
-			if (target.bottom + this._hover.containerDomNode.clientHeight + hoverPointerOffset > this._targetWindow.innerHeight) {
+			if (target.bottom + this._hover.containerDomNode.offsetHeight + hoverPointerOffset > this._targetWindow.innerHeight) {
 				this._hoverPosition = HoverPosition.ABOVE;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -553,7 +553,7 @@ export class HoverWidget extends Widget implements IHoverWidget {`
`553`	`553`	`// Position hover below the target`
`554`	`554`	`else if (this._hoverPosition === HoverPosition.BELOW) {`
`555`	`555`	`// Hover on bottom is going beyond window`
`556`		`- if (target.bottom + this._hover.containerDomNode.clientHeight + hoverPointerOffset > this._targetWindow.innerHeight) {`
	`556`	`+ if (target.bottom + this._hover.containerDomNode.offsetHeight + hoverPointerOffset > this._targetWindow.innerHeight) {`
`557`	`557`	`this._hoverPosition = HoverPosition.ABOVE;`
`558`	`558`	`}`
`559`	`559`	`}`