Skip to content

Commit 59eb29a

Browse files
authored
Merge pull request #300 from gradle/pshevche/fix-testng-tests
Fix assertions on parameterized test names for older Gradle versions
2 parents f16a751 + 63f0c62 commit 59eb29a

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

plugin/src/test/groovy/org/gradle/testretry/testframework/TestNGViaJUnitEngineFuncTest.groovy

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ class TestNGViaJUnitEngineFuncTest extends BaseTestNGFuncTest {
3232
private static final EnumSet<TestNGLifecycleType> CLASS_LIFECYCLE_METHODS = EnumSet.of(BEFORE_CLASS, BEFORE_METHOD, AFTER_METHOD)
3333

3434
private static final GradleVersion GRADLE_5_0 = GradleVersion.version("5.0")
35-
private static final GradleVersion GRADLE_5_4_1 = GradleVersion.version("5.4.1")
35+
private static final GradleVersion GRADLE_6_1 = GradleVersion.version("6.1")
36+
private static final GradleVersion GRADLE_7_0 = GradleVersion.version("7.0")
37+
private static final GradleVersion GRADLE_7_6_4 = GradleVersion.version("7.6.4")
38+
private static final GradleVersion GRADLE_8_1 = GradleVersion.version("8.1")
3639

3740
def setup() {
3841
buildFile << """
@@ -55,9 +58,12 @@ class TestNGViaJUnitEngineFuncTest extends BaseTestNGFuncTest {
5558

5659
@Override
5760
String reportedParameterizedMethodName(String gradleVersion, String methodName, String paramType, int invocationNumber, @Nullable String paramValueRepresentation) {
58-
GradleVersion.version(gradleVersion) > GRADLE_5_4_1
59-
? "${methodName}(${paramType}) > [${invocationNumber}] ${paramValueRepresentation ?: ''}"
60-
: "${methodName}(${paramType})[${invocationNumber}]"
61+
switch (GradleVersion.version(gradleVersion)) {
62+
case { it < GRADLE_6_1 }: return "${methodName}(${paramType})[${invocationNumber}]"
63+
case { it < GRADLE_7_0 }: return "[${invocationNumber}] ${paramValueRepresentation ?: ''}"
64+
case { it < GRADLE_8_1 && it != GRADLE_7_6_4 }: return "${methodName}(${paramType})[${invocationNumber}]"
65+
default: return "${methodName}(${paramType}) > [${invocationNumber}] ${paramValueRepresentation ?: ''}"
66+
}
6167
}
6268

6369
@Override

0 commit comments

Comments
 (0)