vid-3

Author: codereviewvideos

app/config/config.yml

@@ -3,7 +3,7 @@ imports:
     - { resource: security.yml }
     - { resource: services.yml }
     - { resource: services/doctrine_entity_repository.yml }
-    - { resource: services/listener.yml }
+    - { resource: services/factory.yml}
     - { resource: services/repository.yml }
 
 # Put parameters here that don't need to change on each machine where the app is deployed

app/config/services/factory.yml

@@ -0,0 +1,6 @@
+services:
+
+    crv.factory.widget:
+        class: AppBundle\Factory\WidgetFactory
+        arguments:
+            - "@crv.clock"

app/config/services/listener.yml

@@ -16,6 +16,7 @@ default:
         - AppBundle\Features\Context\WidgetSetupContext:
             em: "@doctrine.orm.entity_manager"
             clock: "@crv.clock"
+            widgetFactory: "@crv.factory.widget"
         - AppBundle\Features\Context\TimeContext:
             clock: "@crv.clock"
 

behat.yml

@@ -38,14 +38,14 @@
         "twig/twig": "^1.0||^2.0"
     },
     "require-dev": {
-        "sensio/generator-bundle": "^3.0",
-        "symfony/phpunit-bridge": "^3.0",
-
         "behat/behat": "^3.1",
         "behat/symfony2-extension": "^2.1",
         "behat/web-api-extension": "~1.0@dev",
         "behatch/contexts": "dev-master",
-        "eightpoints/guzzle-bundle": "^6.0"
+        "eightpoints/guzzle-bundle": "^6.0",
+        "phpspec/phpspec": "^4.0",
+        "sensio/generator-bundle": "^3.0",
+        "symfony/phpunit-bridge": "^3.0"
     },
     "scripts": {
         "symfony-scripts": [

composer.json

@@ -3,6 +3,7 @@
 namespace AppBundle\Controller;
 
 use AppBundle\Entity\Widget;
+use AppBundle\Form\Type\WidgetType;
 use AppBundle\Repository\WidgetRepository;
 use FOS\RestBundle\View\View;
 use FOS\RestBundle\Controller\Annotations;
@@ -68,4 +69,77 @@ public function cgetAction(
     {
         return $widgetRepository->findAll();
     }
+
+
+    /**
+     * Create new Widget from the submitted data
+     *
+     * @Annotations\Post(path="/widget")
+     */
+    public function postAction(Request $request)
+    {
+        // creates a Widget with the `createdAt` property already set
+        $widget = $this->get('crv.factory.widget')->create();
+
+        $form = $this->createForm(WidgetType::class, $widget, [
+            'csrf_protection' => false,
+        ]);
+
+        $form->submit($request->request->all(), false);
+
+        if (!$form->isValid()) {
+            return $form;
+        }
+
+        $widget = $form->getData();
+
+        $em = $this->getDoctrine()->getManager();
+        $em->persist($widget);
+        $em->flush();
+
+        $routeOptions = [
+            'id'      => $widget->getId(),
+            '_format' => $request->get('_format'),
+        ];
+
+        return $this->routeRedirectView('get_widget', $routeOptions, Response::HTTP_CREATED);
+    }
+
+    /**
+     * Update existing Widget from the submitted data
+     *
+     * @Annotations\Put(path="/widget/{id}")
+     */
+    public function putAction(Request $request, int $id)
+    {
+        // getRepo() being a private method to return
+        // whatever repo we have configured
+        $widget = $this->getRepo()->find($id);
+
+        $form = $this->createForm(WidgetType::class, $widget, [
+            'csrf_protection' => false,
+        ]);
+
+        $form->submit($request->request->all(), false);
+
+        if (!$form->isValid()) {
+            return $form;
+        }
+
+        $widget = $form->getData();
+
+        // a manual process
+        $widget->setUpdatedAt();
+
+        $em = $this->getDoctrine()->getManager();
+        $em->flush();
+
+        $routeOptions = [
+            'id'      => $widget->getId(),
+            '_format' => $request->get('_format'),
+        ];
+
+        return $this->routeRedirectView('get_widget', $routeOptions, Response::HTTP_NO_CONTENT);
+    }
+
 }

composer.lock

@@ -9,7 +9,6 @@
 /**
  * @ORM\Entity()
  * @ORM\Table(name="widget")
- * @ORM\HasLifecycleCallbacks()
  * @JMSSerializer\ExclusionPolicy("all")
  */
 class Widget

src/AppBundle/Controller/WidgetController.php

@@ -3,6 +3,7 @@
 namespace AppBundle\Features\Context;
 
 use AppBundle\Entity\Widget;
+use AppBundle\Factory\WidgetFactory;
 use AppBundle\Model\Clock;
 use Behat\Behat\Context\Context;
 use Behat\Gherkin\Node\TableNode;
@@ -19,6 +20,10 @@ class WidgetSetupContext implements Context
      * @var Clock
      */
     private $clock;
+    /**
+     * @var WidgetFactory
+     */
+    private $widgetFactory;
 
     /**
      * WidgetSetupContext constructor.
@@ -28,11 +33,13 @@ class WidgetSetupContext implements Context
      */
     public function __construct(
         EntityManagerInterface $em,
-        Clock $clock
+        Clock $clock,
+        WidgetFactory $widgetFactory
     )
     {
         $this->em = $em;
         $this->clock = $clock;
+        $this->widgetFactory = $widgetFactory;
     }
 
     /**
@@ -42,35 +49,18 @@ public function thereAreWidgetsWithTheFollowingDetails(TableNode $widgets)
     {
         foreach ($widgets->getColumnsHash() as $key => $val) {
 
-            $widget = (new Widget())
+            $widget = $this->widgetFactory->create()
                 ->setName($val['name'])
-            ;
-
-            $this->em->persist($widget);
-            $this->em->flush();
-
-
-            $qb = $this->em->createQueryBuilder();
-
-            $query = $qb->update('AppBundle:Widget', 'w')
-                ->set(
-                    'w.createdAt',
-                    $qb->expr()->literal(
-                        $this->clock->now()->modify($val['created_at'])->format('c')
-                    )
+                ->setCreatedAt(
+                    $this->clock->now()->modify($val['created_at'])
                 )
-                ->set(
-                    'w.updatedAt',
-                    $qb->expr()->literal(
-                        $this->clock->now()->modify($val['updated_at'])->format('c')
-                    )
+                ->setUpdatedAt(
+                    $this->clock->now()->modify($val['updated_at'])
                 )
-                ->where('w.id = :id')
-                ->setParameter('id', $widget->getId())
-                ->getQuery()
             ;
 
-            $query->execute();
+            $this->em->persist($widget);
+            $this->em->flush();
         }
     }
 }

src/AppBundle/Entity/Widget.php

@@ -26,4 +26,21 @@ Feature: Manage Widget data via a JSON API
           "created_at": "2019-12-25T00:00:00+0000",
           "updated_at": "2019-12-31T23:55:00+0000"
       }
-      """
+      """
+
+
+  Scenario: Can add a new Widget
+    When I send a "POST" request to "/widget" with body:
+       """
+       {
+          "name": "new widget"
+       }
+       """
+    Then the response code should be 201
+     And I follow the link in the Location response header
+    Then the response should contain json:
+      """
+      {
+          "name": "new widget"
+      }
+      """