Merge pull request #49694 from fatkodima/fix-file_store-key-splitting

Fix file cache store `delete_matched` to work on keys longer than allowed filename size

Author: jonathanhefner

activesupport/lib/active_support/cache/file_store.rb

@@ -176,7 +176,7 @@ def normalize_key(key, options)
 
         # Translate a file path into a key.
         def file_path_key(path)
-          fname = path[cache_path.to_s.size..-1].split(File::SEPARATOR, 4).last
+          fname = path[cache_path.to_s.size..-1].split(File::SEPARATOR, 4).last.delete(File::SEPARATOR)
           URI.decode_www_form_component(fname, Encoding::UTF_8)
         end
 

activesupport/test/cache/stores/file_store_test.rb

@@ -91,6 +91,18 @@ def test_key_transformation_max_filename_size
     assert_equal "B", File.basename(path)
   end
 
+  def test_delete_matched_when_key_exceeds_max_filename_size
+    submaximal_key = "_" * (ActiveSupport::Cache::FileStore::FILENAME_MAX_SIZE - 1)
+
+    @cache.write(submaximal_key + "AB", "value")
+    @cache.delete_matched(/AB/)
+    assert_not @cache.exist?(submaximal_key + "AB")
+
+    @cache.write(submaximal_key + "/A", "value")
+    @cache.delete_matched(/A/)
+    assert_not @cache.exist?(submaximal_key + "/A")
+  end
+
   # If nothing has been stored in the cache, there is a chance the cache directory does not yet exist
   # Ensure delete_matched gracefully handles this case
   def test_delete_matched_when_cache_directory_does_not_exist