Bugfix for an apparent infinite loop in grammar. #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a case of semantically equivalent regex not being computationally equivalent. The issue also relates to how negative character classes (e.g. `[^abc]`) are treated. In the end I had to replace something of the form `(A | B)*` with `A* (BA*)*` to avoid grinding the regex engine to a halt. Issue #150.
elprans
approved these changes
Oct 3, 2018
Member
elprans
left a comment
There was a problem hiding this comment.
I confirm that this fixes MagicPython in VSCode for me.
1st1
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elvis, can you please verify that this fix works for you, too?
This is a case of semantically equivalent regex not being computationally equivalent. The issue also relates to how negative character classes (e.g.
[^abc]) are treated. In the end I had to replace something of the form(A | B)*withA* (BA*)*to avoid grinding the regex engine to a halt.Issue #150.